feat!: all packages should depend on core #3613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: breaking change to mark new versioning requirements
BREAKING CHANGE: breaking change to mark new versioning requirements
Salakar
changed the title
stefkampen
pushed a commit
to stefkampen/react-native-firebase
that referenced
this pull request
Jun 6, 2020
All packages now peer-depend on an explicit version of the `app` package. BREAKING CHANGE: breaking change to mark new internal versioning requirements.
8 tasks
andersondanilo
pushed a commit
to vixtech/react-native-firebase
that referenced
this pull request
Nov 9, 2020
All packages now peer-depend on an explicit version of the `app` package. BREAKING CHANGE: breaking change to mark new internal versioning requirements.
andersondanilo
pushed a commit
to vixtech/react-native-firebase
that referenced
this pull request
Nov 9, 2020
All packages now peer-depend on an explicit version of the `app` package. BREAKING CHANGE: breaking change to mark new internal versioning requirements.
hmhm2292
pushed a commit
to hmhm2292/react-native-firebase
that referenced
this pull request
Jul 13, 2021
All packages now peer-depend on an explicit version of the `app` package. BREAKING CHANGE: breaking change to mark new internal versioning requirements.
androidIsForVivek
pushed a commit
to androidIsForVivek/react-native-firebase
that referenced
this pull request
Aug 9, 2021
All packages now peer-depend on an explicit version of the `app` package. BREAKING CHANGE: breaking change to mark new internal versioning requirements.
androidIsForVivek
pushed a commit
to androidIsForVivek/react-native-firebase
that referenced
this pull request
Sep 15, 2021
All packages now peer-depend on an explicit version of the `app` package. BREAKING CHANGE: breaking change to mark new internal versioning requirements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up PR to allowing every RNFirebase package to be independently versioned whilst still relying on the Core/App package for native SDK versions.
For now the behaviour when a mismatch is detected is to warn on native build outputs, e.g. Gradle build or iOS pod install. We're warning as a different version isn't necessarily going to cause an issue, but it could.
Related issues
Release Summary
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Android:
iOS:
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter