🔥 Performance Monitoring module crashing the app on iOS #3736
Comments
|
@Salakar / @Ehesp crash report with workaround and offer for PR, look good? |
mikehardy
added
impact: crash
|
Oh - @MrSltunUxbert make sure it still applies on new versions, I just checked yours and you look like you are a little bit behind current |
|
@mikehardy I will update the package to the latest version on npm and test if it still crashes |
|
Yeah that looks correct, I think we had this problem on a few of the other modules. |
|
@MrSltunUxbert After a little bit of testing it seems to be working with the current release too (7.1.4) |
|
Having the same problem. When will the fix make it into the official release? Alternatively, @MrSltunUxbert do you have a version that we can point our package.json towards? |
|
@gilbertl -> https://github.com/ds300/patch-package - don't develop with react-native modules without it... |
|
In the meantime, if you use patch-package you can use this patch to fix it until a new release is out.
--- a/node_modules/@react-native-firebase/perf/ios/RNFBPerf/RNFBPerfModule.m
+++ b/node_modules/@react-native-firebase/perf/ios/RNFBPerf/RNFBPerfModule.m
@@ -44,11 +44,11 @@
- (void)dealloc {
@synchronized ([self class]) {
- for (NSString *key in traces) {
+ for (NSString *key in [traces allKeys]) {
[traces removeObjectForKey:key];
}
- for (NSString *key in httpMetrics) {
+ for (NSString *key in [httpMetrics allKeys]) {
[httpMetrics removeObjectForKey:key];
}
}
|
This is great. Didn't know about it. Thanks so much. |
|
Hello 👋, to help manage issues we automatically close stale issues.
|
stale
bot
added
the
Type: Stale
|
I don't think this issue has been fixed yet? |
stale
bot
removed
the
Type: Stale
Issue
I installed the performance monitoring module into our application, it works fine and reports to firebase, but sometimes it the app crashes.
And the issue was
Collection <__NSDictionaryM: 0x600002b7e1c0> was mutated while being enumeratedI looked into it and read the error reports, it seemed like the function
deallocinRNFBPerfModule.mwas causing the issue.What I did was, I changed the
deallocfunction to this:- (void)dealloc { @synchronized ([self class]) { - for (NSString *key in traces) { + for (NSString *key in [traces allKeys]) { [traces removeObjectForKey:key]; } - for (NSString *key in httpMetrics) { + for (NSString *key in [httpMetrics allKeys]) { [httpMetrics removeObjectForKey:key]; } }reference: https://coderwall.com/p/qsty1w/safely-remove-nsmutabledictionary-objects-in-a-loop
I'm not an experienced iOS developer, so I don't know if that's a good solution or not, but it worked for me and since I changed the code, the app didn't crash.
If that's a good solution, I'd be happy to send a PR.
Project Files
Javascript
Click To Expand
package.json:{ "name": "XYZ", "version": "1.0.0", "private": true, "scripts": { "android": "react-native run-android", "ios": "react-native run-ios", "start": "react-native start", "test": "jest", "lint": "eslint .", }, "dependencies": { "@expo/react-native-action-sheet": "^3.6.0", "@react-native-community/async-storage": "^1.8.1", "@react-native-community/datetimepicker": "^2.3.0", "@react-native-community/masked-view": "^0.1.7", "@react-native-community/netinfo": "^5.8.0", "@react-native-firebase/analytics": "^6.3.4", "@react-native-firebase/app": "^6.3.4", "@react-native-firebase/crashlytics": "^6.3.4", "@react-native-firebase/perf": "6.3.4", "@react-navigation/bottom-tabs": "^5.1.1", "@react-navigation/native": "^5.0.9", "@react-navigation/stack": "^5.2.0", "axios": "^0.19.2", "date-fns": "^2.10.0", "date-fns-tz": "^1.0.10", "mobx": "^5.15.4", "mobx-react": "^6.1.8", "moment": "^2.24.0", "react": "16.9.0", "react-hook-form": "^5.1.3", "react-native": "0.61.5", "react-native-android-keyboard-adjust": "^1.2.0", "react-native-animatable": "^1.3.3", "react-native-calendar-events": "^1.7.3", "react-native-collapsible": "^1.5.1", "react-native-gesture-handler": "^1.6.0", "react-native-image-zoom-viewer": "^2.2.27", "react-native-invertible-scroll-view": "^2.0.0", "react-native-iphone-x-helper": "^1.2.1", "react-native-keyboard-aware-scroll-view": "^0.9.1", "react-native-linear-gradient": "^2.5.6", "react-native-modal-datetime-picker": "^8.5.1", "react-native-network-info": "^5.2.1", "react-native-pdf": "^6.1.1", "react-native-permissions": "^2.0.9", "react-native-picker-select": "^6.6.0", "react-native-radio-buttons-ext": "^2.0.0", "react-native-read-more-text": "^1.1.2", "react-native-reanimated": "^1.7.0", "react-native-restart": "^0.0.14", "react-native-safe-area-context": "^0.7.3", "react-native-screens": "^2.3.0", "react-native-share": "^3.1.2", "react-native-swiper": "^1.6.0", "react-native-vector-icons": "^6.6.0", "react-native-webview": "^9.0.1", "rn-fetch-blob": "^0.12.0", "validator": "^12.2.0" }, "devDependencies": { "@babel/core": "^7.8.7", "@babel/runtime": "^7.8.7", "@react-native-community/eslint-config": "^0.0.7", "babel-jest": "^25.1.0", "eslint": "^6.8.0", "jest": "^25.1.0", "metro-react-native-babel-preset": "^0.58.0", "patch-package": "^6.2.2", "pre-commit": "^1.2.2", "react-test-renderer": "16.9.0" }, "jest": { "preset": "react-native" } }firebase.jsonfor react-native-firebase v6:# N/AiOS
Click To Expand
ios/Podfile:AppDelegate.m:Android
Click To Expand
Have you converted to AndroidX?
android/gradle.settingsjetifier=truefor Android compatibility?jetifierfor react-native compatibility?android/build.gradle:// N/Aandroid/app/build.gradle:// N/Aandroid/settings.gradle:// N/AMainApplication.java:// N/AAndroidManifest.xml:<!-- N/A -->Environment
Click To Expand
react-native infooutput:react-native-firebaseversion you're using that has this issue:6.3.4Firebasemodule(s) you're using that has the issue:Performance MonitoringTypeScript?NoThe text was updated successfully, but these errors were encountered: