Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(perf,ios): Corrected enumeration problem in perf module #3978

Merged
merged 3 commits into from
Jul 23, 2020
Merged

fix(perf,ios): Corrected enumeration problem in perf module #3978

merged 3 commits into from
Jul 23, 2020

Conversation

andersonaddo
Copy link
Contributor

mikehardy
mikehardy approved these changes Jul 21, 2020
View reviewed changes
Copy link
Collaborator

@mikehardy mikehardy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can't believe that sat as code in an issue for this long, no one on that issue could make a PR? Fascinating

@mikehardy
Copy link
Collaborator

@Salakar ready for merge I think but I don't trust my taste on squashing and naming things etc, so I'll watch how you do it for future

@Salakar Salakar merged commit 4308810 into master Jul 23, 2020
@mikehardy mikehardy deleted the andersonaddo-patch-1 branch December 17, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehardy mikehardy mikehardy approved these changes

@Salakar Salakar Salakar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🔥 Performance Monitoring module crashing the app on iOS
3 participants
@andersonaddo @mikehardy @Salakar