fixed null token in getToken() on Android #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
efstathiosntonas
changed the title
Ehesp
reviewed
Dec 2, 2018
android/src/main/java/io/invertase/firebase/messaging/RNFirebaseMessaging.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1724 +/- ##
==========================================
+ Coverage 76.1% 76.15% +0.05%
==========================================
Files 72 72
Lines 1837 1837
==========================================
+ Hits 1398 1399 +1
+ Misses 439 438 -1 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1724 +/- ##
==========================================
+ Coverage 76.1% 76.15% +0.05%
==========================================
Files 72 72
Lines 1837 1837
==========================================
+ Hits 1398 1399 +1
+ Misses 439 438 -1 |
Salakar
approved these changes
Dec 2, 2018
Ehesp
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
nulltoken whengetToken()on Android devices/emulatorsFixes #1429
Checklist
AndroidiOSe2etests added or updated in /tests/e2e/*Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter