Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX][TYPESCRIPT][functions] add overload constructor for changing functions region or app #2131

Merged
merged 4 commits into from
Jun 10, 2019

Conversation

tkow
Copy link

@tkow tkow commented May 13, 2019

#1963

fix constructor of functions module.

Summary

We must do unnecessary cast functions type when it's not.

Checklist

  • Supports Android
  • Supports iOS
  • e2e tests added or updated in /tests/e2e/*
  • Updated the documentation in the docs repo
    • LINK TO DOCS PR HERE
  • Flow types updated
  • Typescript types updated

Test Plan

Release Plan

[ TYPES] [BREAKING][FUNCTIONS] - add overload constructor type of functions for changing region or app


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@CLAassistant
Copy link

CLAassistant commented May 13, 2019

CLA assistant check
All committers have signed the CLA.

@mikehardy
Copy link
Collaborator

@tkow I'm planning a 5.4.x release shortly, and a v5.5.x which will allow small breaking changes. You listed this as a breaking change but the new type signature lists all parameters as optional, so I don't believe this is breaking. What do you think?

If I am right and it is not breaking, we can ship this in a v5.4.x release shortly

@mikehardy mikehardy added this to the v5.4.x milestone Jun 9, 2019
@mikehardy mikehardy added Workflow: Waiting for User Response Blocked waiting for user response. plugin: functions Firebase Cloud Functions tools: typings TypeScript / Flow Type: Bug Fix labels Jun 9, 2019
@tkow
Copy link
Author

tkow commented Jun 10, 2019

@mikehardy I think so, too. It should not be broken unless changing native firebase sdk.

@mikehardy
Copy link
Collaborator

@Salakar I hate to keep pointing TeamCity things which are sort of meta, but as it's new CI hopefully it's helpful? It's blocker for merges though either way.

Anyway, I updated this one from branch on the way to merge, but it didn't get updated status. So I looked and it looks like all the 3 compatible agents for ci.analyse are disconnected? https://ci.invertase.io/viewQueued.html?itemId=981&buildTypeId=InvertaseOSS_ReactNativeFirebase_CiAnalyse&tab=queuedBuildOverviewTab

@codecov
Copy link

codecov bot commented Jun 10, 2019

Codecov Report

❗ No coverage uploaded for pull request base (v5.x.x@eab6862). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             v5.x.x    #2131   +/-   ##
=========================================
  Coverage          ?   72.62%           
=========================================
  Files             ?       64           
  Lines             ?     1592           
  Branches          ?        0           
=========================================
  Hits              ?     1156           
  Misses            ?      436           
  Partials          ?        0

@mikehardy mikehardy changed the title [5.x.x][functions] add overload constructor type of functions for changing region or app [FIX][TYPESCRIPT][functions] add overload constructor for changing functions region or app Jun 10, 2019
@mikehardy mikehardy merged commit ce72d10 into invertase:v5.x.x Jun 10, 2019
@mikehardy
Copy link
Collaborator

thank you @tkow ! merged, and will be in 5.4.3

@tkow tkow deleted the v5.x.x branch June 11, 2019 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: functions Firebase Cloud Functions tools: typings TypeScript / Flow Workflow: Waiting for User Response Blocked waiting for user response.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants