-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX][TYPESCRIPT][functions] add overload constructor for changing functions region or app #2131
Conversation
…tiple firebase apps
@tkow I'm planning a 5.4.x release shortly, and a v5.5.x which will allow small breaking changes. You listed this as a breaking change but the new type signature lists all parameters as optional, so I don't believe this is breaking. What do you think? If I am right and it is not breaking, we can ship this in a v5.4.x release shortly |
@mikehardy I think so, too. It should not be broken unless changing native firebase sdk. |
@Salakar I hate to keep pointing TeamCity things which are sort of meta, but as it's new CI hopefully it's helpful? It's blocker for merges though either way. Anyway, I updated this one from branch on the way to merge, but it didn't get updated status. So I looked and it looks like all the 3 compatible agents for ci.analyse are disconnected? https://ci.invertase.io/viewQueued.html?itemId=981&buildTypeId=InvertaseOSS_ReactNativeFirebase_CiAnalyse&tab=queuedBuildOverviewTab |
Codecov Report
@@ Coverage Diff @@
## v5.x.x #2131 +/- ##
=========================================
Coverage ? 72.62%
=========================================
Files ? 64
Lines ? 1592
Branches ? 0
=========================================
Hits ? 1156
Misses ? 436
Partials ? 0 |
thank you @tkow ! merged, and will be in 5.4.3 |
#1963
fix constructor of functions module.
Summary
We must do unnecessary cast functions type when it's not.
Checklist
Android
iOS
e2e
tests added or updated in /tests/e2e/*Test Plan
Release Plan
[ TYPES] [BREAKING][FUNCTIONS] - add overload constructor type of functions for changing region or app
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter