Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] v6 Implement Cloud Messaging #2330

Merged
merged 28 commits into from
Jul 12, 2019
Merged

[WIP] v6 Implement Cloud Messaging #2330

merged 28 commits into from
Jul 12, 2019

Conversation

Salakar
Copy link
Member

@Salakar Salakar commented Jul 7, 2019 •
edited

Todo

  • Tests coverage
  • Manual iOS tests
  • Arg validations
  • Complete iOS integration docs
  • Complete types documentation/commenting

This is not notifications.

[Changelog]

Think react-native-firebase is great? Please consider supporting the project with any of the below:

@Salakar Salakar added plugin: messaging FCM only - ( messaging() ) - do not use for Notifications Version: 6.x.x labels Jul 7, 2019
@Salakar Salakar mentioned this pull request Jul 7, 2019
Closed
@codecov
Copy link

codecov bot commented Jul 7, 2019 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@a966c20). Click here to learn what that means.
The diff coverage is 22.59%.

@@           Coverage Diff            @@
##             master   #2330   +/-   ##
========================================
  Coverage          ?   12.2%           
========================================
  Files             ?      60           
  Lines             ?    1484           
  Branches          ?       0           
========================================
  Hits              ?     181           
  Misses            ?    1303           
  Partials          ?       0

@Salakar Salakar self-assigned this Jul 11, 2019
@Salakar Salakar added this to 💛 In progress in React Native Firebase - v6 via automation Jul 11, 2019
@Salakar Salakar added this to the v6.0.0 milestone Jul 11, 2019
@Salakar Salakar merged commit 85672a4 into master Jul 12, 2019
React Native Firebase - v6 automation moved this from 💛 In progress to 💚 Done Jul 12, 2019
@schachris
Copy link

seems like its already in master...when will you publish messaging to npm?

@Salakar Salakar deleted the @salakar/v6/messaging branch July 31, 2019 13:18
@Salakar
Copy link
Member Author

Salakar commented Jul 31, 2019

@cschaffr this was published to npm yesterday.

@invertase invertase locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Salakar Salakar

Labels
platform: android platform: ios platform: javascript plugin: messaging FCM only - ( messaging() ) - do not use for Notifications
Projects
No open projects
React Native Firebase - v6
  
💚 Done
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Salakar @schachris @Ehesp