fix(storage, ios): fix build failure for catalyst compiles

[mikehardy]

Description

The whole system appears to build and run just fine as a catalyst app on macOS machines, with the one exception of this build issue here

discovered while working on general react-native catalyst issues -

Related issues

facebook/flipper#3117

Release Summary

conventional commit message

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Yes
• My change supports the following platforms;
  • Android
  • iOS
• My change includes tests;
  • e2e tests added or updated in packages/\*\*/e2e
  • jest tests added or updated in packages/\*\*/__tests__
• I have updated TypeScript types that are affected by my change.
• This is a breaking change;
  • Yes
  • No

Test Plan

E2E tests exercise it a bit, I'm going to check out the test coverage to make sure that these lines were hit on iOS, if they weren't (yet) I'll add a test to make sure they are exercised

---

Think react-native-firebase is great? Please consider supporting the project with any of the below:

• 👉 Star this repo on GitHub ⭐️
• 👉 Follow React Native Firebase and Invertase on Twitter

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-native-firebase – ./

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/7wa5kAVB54puqRW7hX7caV1Q2AYz
✅ Preview: https://react-native-firebase-git-mikehardy-storage-ca-16259a-invertase.vercel.app

react-native-firebase-next – ./website_modular

🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/FZTduwt3rpePwaRrFRXt6ekPDidv
✅ Preview: Canceled

[codecov]

Codecov Report

Merging #6128 (d8afaf4) into main (4060827) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head d8afaf4 differs from pull request most recent head fb12f0e. Consider uploading reports for the commit fb12f0e to get more accurate results

@@             Coverage Diff              @@
##               main    #6128      +/-   ##
============================================
+ Coverage     52.92%   52.94%   +0.02%     
  Complexity      622      622              
============================================
  Files           208      208              
  Lines         10220    10220              
  Branches       1626     1626              
============================================
+ Hits           5408     5410       +2     
+ Misses         4558     4556       -2     
  Partials        254      254              

[mikehardy]

This does not have test coverage, asking for a second set of eyes

[russellwheatley]

The only issue I could think of would be another sneaky Task that is resumable. Double checked the docs and they are the only resumable tasks. Also - CI tests passing for upload/download. LGTM.

[mikehardy]

Fantastic, I really appreciate the second set of eyes, thanks @russellwheatley
I suppose even if it's mis-cast because a sneaky non-upload/non-download task creeps in, in the future, it will still actually respond to resume...and...should just work then as well 🤔