Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage, ios): fix build failure for catalyst compiles #6128

Merged
merged 1 commit into from
Mar 15, 2022
Merged

fix(storage, ios): fix build failure for catalyst compiles #6128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/storage/ios/RNFBStorage/RNFBStorageModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,11 @@ - (void)invalidate {
[task pause];
break;
case 1:
[task resume];
if ([task isKindOfClass:[FIRStorageDownloadTask class]]) {
[(FIRStorageDownloadTask *)task resume];
} else {
[(FIRStorageUploadTask *)task resume];
}
break;
case 2:
[task cancel];
Expand Down
8 changes: 4 additions & 4 deletions tests/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ PODS:
- Firebase/Storage (8.12.1):
- Firebase/CoreOnly
- FirebaseStorage (~> 8.12.0)
- FirebaseABTesting (8.12.0):
- FirebaseABTesting (8.13.0):
- FirebaseCore (~> 8.0)
- FirebaseAnalytics (8.12.0):
- FirebaseAnalytics/AdIdSupport (= 8.12.0)
Expand Down Expand Up @@ -442,7 +442,7 @@ PODS:
- FirebaseCoreDiagnostics (~> 8.0)
- GoogleUtilities/Environment (~> 7.7)
- GoogleUtilities/Logger (~> 7.7)
- FirebaseCoreDiagnostics (8.12.0):
- FirebaseCoreDiagnostics (8.13.0):
- GoogleDataTransport (~> 9.1)
- GoogleUtilities/Environment (~> 7.7)
- GoogleUtilities/Logger (~> 7.7)
Expand Down Expand Up @@ -1117,13 +1117,13 @@ SPEC CHECKSUMS:
FBLazyVector: 808f741ddb0896a20e5b98cc665f5b3413b072e2
FBReactNativeSpec: 94473205b8741b61402e8c51716dea34aa3f5b2f
Firebase: 580d09e8edafc3073ebf09c03fd42e4d80d35fe9
FirebaseABTesting: 1b05c92327b3f0a9545cea3bab4d93e82550e29b
FirebaseABTesting: c390fb900b9dd6e9c04888e34dda8e9e84b07195
FirebaseAnalytics: bd10d7706ba8d6e01ea2816f8fe9e9b881cb0918
FirebaseAppCheck: b91624d3f8c262eae9bfc1486b640d8c13787abc
FirebaseAppDistribution: d1cf955c7e2d08567646b3eb453309d4ae850b23
FirebaseAuth: 5250d7bdba35e57cc34ec7ddc525f82b2757f2a0
FirebaseCore: 8138de860a90ca7eec5e324da5788fb0ebf1d93c
FirebaseCoreDiagnostics: 3b40dfadef5b90433a60ae01f01e90fe87aa76aa
FirebaseCoreDiagnostics: c2836d254a8f0bbb4121ff18f2c2ea39d118fd08
FirebaseCrashlytics: 7952ffd988006128325510664b99dc8ca5851dff
FirebaseDatabase: f130b3d45b2a7a0b86059734d5bd67353df8d32f
FirebaseDynamicLinks: 98a5f0fe542245a89ec55f646d2581298c29219d
Expand Down