Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): firebase-ios-sdk 10.20.0 / firebase-android-sdk 32.7.1 #7585

Merged
merged 5 commits into from Jan 22, 2024

Conversation

mikehardy
Copy link
Collaborator

Description

Standard dependency updates - has updates for both underlying SDKs

Related issues

Release Summary

Conventional commits

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Local test suites, all passing


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Jan 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 11:14pm
react-native-firebase-next ❌ Failed (Inspect) Jan 22, 2024 11:14pm

… init

it really wants to initialize things if you are not in the new interop mode,
and if you set the new interop mode then you need platform constants
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Merging #7585 (be15598) into main (57ed042) will decrease coverage by 14.88%.
The diff coverage is n/a.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #7585       +/-   ##
=============================================
- Coverage     68.20%   53.31%   -14.88%     
- Complexity        0      742      +742     
=============================================
  Files           149      251      +102     
  Lines          5933    12420     +6487     
  Branches       1248     1938      +690     
=============================================
+ Hits           4046     6621     +2575     
- Misses         1790     5449     +3659     
- Partials         97      350      +253     

@mikehardy mikehardy merged commit 55c1c2c into main Jan 22, 2024
17 of 19 checks passed
@mikehardy mikehardy deleted the @mikehardy/dependency-updates branch January 22, 2024 23:59
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant