Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk, android): adopt firebase-android-sdk 32.7.1 #7584

Closed
wants to merge 1 commit into from

Conversation

wfern
Copy link

@wfern wfern commented Jan 22, 2024

Description

Fixes #7561

Issue in the firebase-android-sdk repository: firebase/firebase-android-sdk#5638

Related issues

Fixes #7561

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

I successfully ran all tests locally


Think react-native-firebase is great? Please consider supporting the project with any of the below:

🔥

Copy link

vercel bot commented Jan 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 2:27pm
react-native-firebase-next ❌ Failed (Inspect) Jan 22, 2024 2:27pm

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2024

CLA assistant check
All committers have signed the CLA.

@mikehardy
Copy link
Collaborator

Hey @wfern 👋 - thanks for proposing this, I appreciate your taking the time to make a PR

You even got the docs update for the version, which is amazing - no one remembers the docs :-)

I already had a dependency updates branch going with this among a few other things and I've just finished working through local testing on it and posted it as #7585 - I'm going to close this in preference to that one since it handles iOS and javascript stuff too but I'll get it merged as soon as I finish one last jest thing and release it shortly

Until then it's released you can use the patch-package patches from the PR in case it's urgent and you haven't already got things patched locally - they should who up here https://github.com/invertase/react-native-firebase/actions/runs/7618122454?pr=7585

@mikehardy mikehardy closed this Jan 22, 2024
@wfern wfern deleted the android-32.7.1 branch January 22, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A critical security vulnerability was discovered in reCAPTCHA
3 participants