fix: enrolledFactors rather than enrolledFactor #7652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mnahkies
force-pushed
the
mn/fix/typo
branch
from
e85cfd1
to
07aa603
Compare
10 tasks
the typescript definitions specify it as `enrolledFactors` reflecting that it is an array, but the javascript was actually setting it as `enrolledFactor` at runtime. ref: - typings: https://github.com/invertase/react-native-firebase/blob/main/packages/auth/lib/index.d.ts#L568 - android: https://github.com/invertase/react-native-firebase/blob/main/packages/auth/android/src/main/java/io/invertase/firebase/auth/ReactNativeFirebaseAuthModule.java#L2476 - ios: https://github.com/invertase/react-native-firebase/blob/main/packages/auth/ios/RNFBAuth/RNFBAuthModule.m#L1681 - web sdk: https://github.com/firebase/firebase-js-sdk/blob/master/packages/auth/src/mfa/mfa_user.ts#L34 BREAKING CHANGE: runtime MFA user property renamed from `enrolledFactor` to `enrolledFactors` and now matches typescript types
mnahkies
changed the title
|
@mikehardy I've adjusted this to be backwards compatible since I missed the v19 release, it would be great if you could take a look 🙏 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7652 +/- ##
===========================================
- Coverage 68.05% 33.24% -34.81%
===========================================
Files 149 251 +102
Lines 5943 12464 +6521
Branches 1250 1944 +694
===========================================
+ Hits 4044 4142 +98
- Misses 1802 8233 +6431
+ Partials 97 89 -8 |
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
|
not stale |
mikehardy
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the typescript definitions specify it as
enrolledFactorsreflecting that it is an array, but the javascript was actually setting it asenrolledFactorat runtime.the original
enrolledFactorproperty is kept for backwards compatibility, but could be removed in a future major version.ref:
Release Summary
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__