Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enrolledFactors rather than enrolledFactor #7652

Merged
merged 2 commits into from
Apr 12, 2024
Merged

fix: enrolledFactors rather than enrolledFactor #7652

merged 2 commits into from
Apr 12, 2024

Commits on Mar 9, 2024

  1. fix!: enrolledFactors rather than enrolledFactor 

    the typescript definitions specify it as `enrolledFactors` reflecting
that it is an array, but the javascript was actually setting it
as `enrolledFactor` at runtime.

ref:
- typings: https://github.com/invertase/react-native-firebase/blob/main/packages/auth/lib/index.d.ts#L568
- android: https://github.com/invertase/react-native-firebase/blob/main/packages/auth/android/src/main/java/io/invertase/firebase/auth/ReactNativeFirebaseAuthModule.java#L2476
- ios: https://github.com/invertase/react-native-firebase/blob/main/packages/auth/ios/RNFBAuth/RNFBAuthModule.m#L1681
- web sdk: https://github.com/firebase/firebase-js-sdk/blob/master/packages/auth/src/mfa/mfa_user.ts#L34

BREAKING CHANGE: runtime MFA user property renamed from `enrolledFactor` to `enrolledFactors` and now matches typescript types
    @mnahkies
    mnahkies committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    c7321a4 View commit details
    Browse the repository at this point in the history

  2. fix: make backwards compatible

    @mnahkies
    mnahkies committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    2457a55 View commit details
    Browse the repository at this point in the history