Property Serialization mode is not remebered for dynamically added properties.

[r-englund]

When loading a network with a processor having one or more dynamically added properties with serialization mode set to All, the properties recreated by the deserializer does not have the serialization mode set to All.

For example: The parallel coordinates have a DataFrameColormapProperty. The DataFrameColormapProperty dynamically adds a bunch of ColormapProperty and set them their serialization mode to All.

inviwo/modules/dataframe/src/properties/dataframecolormapproperty.cpp

Lines 101 to 114 in 1f3aba2

	auto colormapProp = [&]() -> ColormapProperty* {
	if (auto p = getPropertyByIdentifier(identifier)) {
	if (auto prop = dynamic_cast<ColormapProperty*>(p)) {
	return prop;
	}
	removeProperty(identifier);
	}
	auto newProp = std::make_unique<ColormapProperty>(identifier, displayName);
	auto ptr = newProp.get();
	newProp->setVisible(false);
	newProp->setSerializationMode(PropertySerializationMode::All);
	insertProperty(1, newProp.release());
	return ptr;
	}();

When the network is saved and have been reloaded the serialization mode of the properties are Default which means the next time the network is saved information such as display name etc. will be lost.

Suggestion: In PropertyOwner, when adding a property to ownedProperties_ the serialization mode should be set to All. IMO, this makes sense since we need it for properties recreated by the deserializer to get, e.g, displayname correct

[r-englund]

Or just remove serialization mode completely, it's not like we save that much disk space right?

[petersteneteg]

would it not be more correct to just serialize it?

[r-englund]

would it not be more correct to just serialize it?

We do serialize it, but if the serialization mode is not set to All we do not serialize everything

[petersteneteg]

Where do we serialize the serialization mode?

[r-englund]

Where do we serialize the serialization mode?

Ahh, I did not realize you meant the serialization mode. But yes, that would be a solution as well I guess, probably the best one.

[petersteneteg]

This is still on my todo I think