Core: Avoid redundant links when pasting

[petersteneteg]

Fixes #...

Changes proposed in this PR:

• ...
• ...
• ...

This has been tested on: ...

Thank you for contributing to the Inviwo repository! Please ensure the following:

• Code is error and warning free
• Code follows the Inviwo coding guidelines:
  https://github.com/inviwo/inviwo/wiki/Coding-Conventions
• New Code / Processors follows the Inviwo documentation guidelines:
  https://github.com/inviwo/inviwo/wiki/Documentation-guide
• New Code / processors are tested in a unittest and / or regression test:
  https://github.com/inviwo/inviwo/wiki/Manual#testing

Please remember to specify the environment this code been compiled and tested on:
Operating System / Compiler / IDE / QT / CMake / Python versions.

[github-actions]

Cpp-Linter Report ✔️

No problems need attention.

Have any feedback or feature suggestions? Share it here.

[github-actions]

Cpp-linter Review

Click here for the full clang-tidy patch

diff --git a/src/core/links/linkevaluator.cpp b/src/core/links/linkevaluator.cpp
index 3b95cae..92740d9 100644
--- a/src/core/links/linkevaluator.cpp
+++ b/src/core/links/linkevaluator.cpp
@@ -207 +207 @@ void LinkEvaluator::evaluateLinksFromProperty(Property* modifiedProperty) {
-    VisitedHelper helper(visited_, links);
+    const VisitedHelper helper(visited_, links);

Have any feedback or feature suggestions? Share it here.

[github-actions]

Cpp-linter Review

Click here for the full clang-tidy patch

diff --git a/src/core/links/linkevaluator.cpp b/src/core/links/linkevaluator.cpp
index b6ccd7a..7867fcc 100644
--- a/src/core/links/linkevaluator.cpp
+++ b/src/core/links/linkevaluator.cpp
@@ -178 +178 @@ void LinkEvaluator::transientCacheHelper(std::vector<ConvertibleLink>& links, Pr
-    if (auto converter = manager->getConverter(src, dst)) {
+    if (const auto* converter = manager->getConverter(src, dst)) {
@@ -195,2 +195,2 @@ void LinkEvaluator::transientCacheHelper(std::vector<ConvertibleLink>& links, Pr
-    if (auto cp = dynamic_cast<CompositeProperty*>(dst)) {
-        for (auto& newSrc : cp->getProperties()) {
+    if (auto* cp = dynamic_cast<CompositeProperty*>(dst)) {
+        for (const auto& newSrc : cp->getProperties()) {
diff --git a/src/core/network/autolinker.cpp b/src/core/network/autolinker.cpp
index 09876d9..b990ba5 100644
--- a/src/core/network/autolinker.cpp
+++ b/src/core/network/autolinker.cpp
@@ -72 +72 @@ AutoLinker::AutoLinker(ProcessorNetwork* network, Processor* target, Processor* 
-    for (auto& targetProperty : targetProperties) {
+    for (const auto& targetProperty : targetProperties) {
@@ -98 +98 @@ AutoLinker::AutoLinker(ProcessorNetwork* network, Processor* target, Processor* 
-                return proc && proc->getClassIdentifier() == processorClassId &&
+                return (proc != nullptr) && proc->getClassIdentifier() == processorClassId &&

Have any feedback or feature suggestions? Share it here.

[github-actions]

Cpp-linter Review

No concerns from clang-tidy.

Great job! 🎉

Have any feedback or feature suggestions? Share it here.