Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cmake dep refactor #969

Merged
merged 19 commits into from Jun 30, 2020
Merged

Cmake dep refactor #969

merged 19 commits into from Jun 30, 2020

Conversation

petersteneteg
Copy link
Member

No description provided.

@petersteneteg
CMake: Refactornig our camke naming scheme. Use IVW_CFG_* for configu…
1688755 
…ration settings. IVW_TEST_* for test settings IVW_APP_* for enabling vaiours apps, IVW_USE_* for enabling various libs Note the PRECOMPILE_HEADERS is not called IVW_CFG_PRECOMPILED_HEADERS
@petersteneteg
Various: Submodule updates
e083397
@petersteneteg
CMake: Restructuring externals. Adding IVW_USE_EXTERNAL_FOO to use ex…
82a4449 
…ternal version of deps instead of the submodules. Added helpes for installing deps from VCPKG. Made Version constexpr.
@petersteneteg
CMake: refactoring handling of external dependencies
c83b8a3
ResearchDaniel
ResearchDaniel previously requested changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@ResearchDaniel ResearchDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Sprinkled comments here and there.
Don’t forget to update changelog.
Wishlist: Would be cool if a package could be created for a single module in the future.

cmake/installutils.cmake Show resolved Hide resolved
cmake/installutils.cmake Outdated Show resolved Hide resolved
cmake/installutils.cmake Show resolved Hide resolved
cmake/installutils.cmake Show resolved Hide resolved
cmake/installutils.cmake Show resolved Hide resolved
ext/CMakeLists.txt Outdated Show resolved Hide resolved
ext/libpng/CMakeLists.txt Show resolved Hide resolved
ext/tinydir/CMakeLists.txt Outdated Show resolved Hide resolved
ext/utf/CMakeLists.txt Outdated Show resolved Hide resolved
modules/cimg/CMakeLists.txt Show resolved Hide resolved
@Inviwo-Team Inviwo-Team removed the J: Build Failure Jenkins build failure label Jun 26, 2020
@petersteneteg petersteneteg marked this pull request as ready for review June 26, 2020 12:57
martinfalk
martinfalk previously approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@martinfalk martinfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

CHANGELOG.md Outdated Show resolved Hide resolved
ext/CMakeLists.txt Outdated Show resolved Hide resolved
apps/inviwo/CMakeLists.txt Outdated Show resolved Hide resolved
cmake/installutils.cmake Outdated Show resolved Hide resolved
cmake/licenses.cmake Outdated Show resolved Hide resolved
ext/tclap/CMakeLists.txt Outdated Show resolved Hide resolved
ext/ticpp/CMakeLists.txt Outdated Show resolved Hide resolved
modules/cimg/CMakeLists.txt Outdated Show resolved Hide resolved
src/qt/editor/inviwoaboutwindow.cpp Outdated Show resolved Hide resolved
src/qt/editor/inviwoaboutwindow.cpp Show resolved Hide resolved
ResearchDaniel
ResearchDaniel reviewed Jun 26, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
cmake/installutils.cmake Outdated Show resolved Hide resolved
modules/cimg/CMakeLists.txt Show resolved Hide resolved
martinfalk
martinfalk previously approved these changes Jun 29, 2020
View reviewed changes
@Inviwo-Team Inviwo-Team added the J: Build Failure Jenkins build failure label Jun 30, 2020
@Inviwo-Team Inviwo-Team removed the J: Build Failure Jenkins build failure label Jun 30, 2020
@petersteneteg petersteneteg merged commit daf392e into master Jun 30, 2020
@petersteneteg petersteneteg deleted the feature/cmake-dep-refactor branch June 30, 2020 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinfalk martinfalk martinfalk approved these changes

@ResearchDaniel ResearchDaniel Awaiting requested review from ResearchDaniel

Assignees
No one assigned
Labels
J: Auto Format
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@petersteneteg @ResearchDaniel @martinfalk @Inviwo-Team