Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tests #2

Closed
m3nu opened this issue May 15, 2018 · 2 comments
Closed

Add Tests #2

m3nu opened this issue May 15, 2018 · 2 comments
Assignees

Comments

@m3nu
Copy link
Collaborator

m3nu commented May 15, 2018

Every module will need some tests. I suggest one test-module per module. E.g. test_facturx.py, test_pdfwriter.py, etc.

There is already a folder with test PDFs. We could have some Json files to compare against for each.

@duskybomb
Copy link

duskybomb commented May 23, 2018

Will be working on tests tomorrow. Making list of functions for which we need tests:

  • _xml_from_file(): checking for pdf with and without embedded metadata.
    • for pdf without pdf check whether metadata has been added or not
    • what should I do for pdf with embedded data?
  • write_pdf()
    • check for pdf in directory
  • write_xml()
    • should I parse it and compare?

@m3nu feel free to add more.

@m3nu
Copy link
Collaborator Author

m3nu commented May 24, 2018

Those are good to start with.

m3nu pushed a commit that referenced this issue Jun 7, 2018
@m3nu m3nu closed this as completed Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants