Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with Modern invoice template which causes the Balance Due amount to have its last digit cut-off. #1104

Closed
wants to merge 2 commits into from

Conversation

d19dotca
Copy link

Changed value of width to 530 from 515 for the "rect" type in the canvas. The value was too small at 515 which caused the "balance due" amount to cut off the last digit.

Changed value of width to 530 from 515 for the "rect" type in the canvas. The value was too small at 515 which caused the "balance due" amount to cut off the last digit.
@d19dotca d19dotca changed the title Fixed width of "rect" type in Modern invoice template. Fix issue with Modern invoice template which caused Balance Due value to have its last digit cut off. Oct 15, 2016
@d19dotca d19dotca changed the title Fix issue with Modern invoice template which caused Balance Due value to have its last digit cut off. Fix issue with Modern invoice template which causes the Balance Due amount to have its last digit cut-off. Oct 15, 2016
@d19dotca
Copy link
Author

Changed it one more time from 530 to 532 as 530 was just a tad too short too.

@hillelcoren
Copy link
Member

Thanks for the fix!

Can you please create the PR against the develop branch

@turbo124 turbo124 added the bug label Oct 18, 2016
@d19dotca
Copy link
Author

Definitely. I'll try to get that done in the next couple of days.

-- 

Dustin Dauncey

  On 2016-10-15 10:33 AM, Hillel Coren wrote:


  Thanks for the fix! 
  Can you please create the PR against the develop branch
  —
    You are receiving this because you authored the thread.
    Reply to this email directly, view
      it on GitHub, or mute
      the thread.







  {"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/invoiceninja/invoiceninja","title":"invoiceninja/invoiceninja","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/invoiceninja/invoiceninja"}},"updates":{"snippets":[{"icon":"PERSON","message":"@hillelcoren in #1104: Thanks for the fix! \r\n\r\nCan you please create the PR against the develop branch"}],"action":{"name":"View Pull Request","url":"https://github.com/invoiceninja/invoiceninja/pull/1104#issuecomment-253998589"}}}

@d19dotca d19dotca changed the base branch from master to develop October 28, 2016 06:44
@d19dotca
Copy link
Author

@hillelcoren, I'm new to GitHub but I think I changed the pull request to be against the Develop base branch. I see that you closed this two days ago... is this still do-able now that I've changed it or do I need to create a new one from scratch?

@hillelcoren hillelcoren reopened this Oct 28, 2016
@hillelcoren
Copy link
Member

There are a lot of conflicts, it's such a small change it may be easier to create a new PR.

@d19dotca
Copy link
Author

Ok. Will do.

d19dotca pushed a commit to d19dotca/invoiceninja that referenced this pull request Oct 29, 2016
Updated modern.js invoice template to fix width issues. This is related to PR invoiceninja#1104. This time it should be put against the correct branch.
@d19dotca
Copy link
Author

Closing this out in favour of the latest pull request (#1128) to replace this one against Develop branch.

@d19dotca d19dotca closed this Oct 29, 2016
turbo124 pushed a commit that referenced this pull request Oct 29, 2016
Updated modern.js invoice template to fix width issues. This is related to PR #1104. This time it should be put against the correct branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants