-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with Modern invoice template which causes the Balance Due amount to have its last digit cut-off. #1104
Conversation
Changed value of width to 530 from 515 for the "rect" type in the canvas. The value was too small at 515 which caused the "balance due" amount to cut off the last digit.
Changed it one more time from 530 to 532 as 530 was just a tad too short too. |
Thanks for the fix! Can you please create the PR against the develop branch |
|
@hillelcoren, I'm new to GitHub but I think I changed the pull request to be against the Develop base branch. I see that you closed this two days ago... is this still do-able now that I've changed it or do I need to create a new one from scratch? |
There are a lot of conflicts, it's such a small change it may be easier to create a new PR. |
Ok. Will do. |
Updated modern.js invoice template to fix width issues. This is related to PR invoiceninja#1104. This time it should be put against the correct branch.
Closing this out in favour of the latest pull request (#1128) to replace this one against Develop branch. |
Updated modern.js invoice template to fix width issues. This is related to PR #1104. This time it should be put against the correct branch.
Changed value of width to 530 from 515 for the "rect" type in the canvas. The value was too small at 515 which caused the "balance due" amount to cut off the last digit.