Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoice surgage label as Discount #1765

Closed
kikoseijo opened this issue Dec 14, 2017 · 2 comments
Closed

Invoice surgage label as Discount #1765

kikoseijo opened this issue Dec 14, 2017 · 2 comments
Labels

Comments

@kikoseijo
Copy link

Hi there,

I think there is a bug, its been for long but I been just translating the label, I think I should report it.

As you see, the label there was supposed to be what I write, but its not, its showing discount instead of my own label.

screen shot 2017-12-14 at 19 09 07

AS you can see here, there is no discount on this Quote, so the label correspond to custom fields in invoice with the label I have set, but shows the one for discount.

screen shot 2017-12-14 at 19 18 20

Let me know if you need extra info, using version 4.0.1

@kikoseijo
Copy link
Author

kikoseijo commented Dec 14, 2017

I have notice the translation files are not performing the fix I was using.

This does not works now, (Didn't update since 3.8.1, so don't know when this stoped working)
screen shot 2017-12-14 at 19 29 33

This fix works now, change it in the invoice design settings.

screen shot 2017-12-14 at 19 26 49

Hope it helps.

@hillelcoren
Copy link
Member

I think I see the problem... There is code which is using 'Discount' if the value is less than 0, we'll remove this in our next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants