let constants be seeded multiple times whithout be duplicated #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found 100 times the themes `readable` in my database ( the same for the other themes in constantsseeder ). Bu it seems that the only point where this value is inserted into the database is in this file. So I assume this is run multiple times. Changing `create` by `firtsOrCreate` should avoid issue du to multiple times playing this seed.
|
Thanks for the change! Rather than check for each row can you add a single check at the top, this approach would generate many extra queries. Also, please create the PR against the develop branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found 100 times the themes
readablein my database ( the same for the other themes in constantsseeder ).Bu it seems that the only point where this value is inserted into the database is in this file.
So I assume this is run multiple times.
Changing
createbyfirtsOrCreateshould avoid issue du to multiple times playing this seed.