Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward dream.py to invoke.py using the same interpreter, add deprecation warning #1077

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Forward dream.py to invoke.py using the same interpreter, add deprecation warning #1077

merged 2 commits into from
Oct 13, 2022

Conversation

db3000
Copy link
Contributor

@db3000 db3000 commented Oct 13, 2022

Just a bit cleaner to forward using import instead of reexecuting python, also running "python3" risks bringing up the wrong interpreter. Added a deprecation warning as well.

CapableWeb
CapableWeb reviewed Oct 13, 2022
View reviewed changes
scripts/dream.py Outdated Show resolved Hide resolved
lstein
lstein approved these changes Oct 13, 2022
View reviewed changes
Copy link
Collaborator

@lstein lstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for showing me how to do this correctly. I was in a bash mindset when I wrote this.

@lstein lstein merged commit 7f491fd into invoke-ai:development Oct 13, 2022
@db3000 db3000 deleted the deprecate_dream branch October 13, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lstein lstein lstein approved these changes

@CapableWeb CapableWeb Awaiting requested review from CapableWeb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@db3000 @lstein @CapableWeb