Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize facetool strength argument #1078

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

db3000
Copy link
Contributor

@db3000 db3000 commented Oct 13, 2022

Take strength for face restoration in the facetool_strength parameter everywhere, instead of gfpgan_strength. This makes usage of non-GFPGAN face restoration much more straightforward, it never made sense to me that I had to pass --ft codeformer --gfpgan_strength 0.5 to run CodeFormer. The change also makes it easier to add more face restoration algorithms and to expose CodeFormer in the web UI.

Mostly just a search and replace, but I left support in for --gfpgan_strength as well on the command line and when loading metadata for backwards compatibility.

@blessedcoolant
Copy link
Collaborator

blessedcoolant commented Oct 13, 2022

I see the parameter name change but is there any functional change made? Because right now it works exactly like that. the gfpgan_strength is basically a face restoration trigger that works with both gfpgan and codeformer. We just didn't rename it when we added codeformer. The changes seem to be just that. Or am I missing something else here?

If it's just the rename, then I'll test everything works in order and approve it.

@db3000
Copy link
Contributor Author

db3000 commented Oct 13, 2022

If it's just the rename, then I'll test everything works in order and approve it.

It's just the rename for now, which improves clarity in the invoke command line UI. I was thinking to use it to add support for CodeFormer in the web UI in a later PR.

@blessedcoolant
Copy link
Collaborator

Okay. Seems good. Please rebase to match the latest changes on dev. Approving this.

@lstein Please do a quick check once before you merge.

@db3000
Copy link
Contributor Author

db3000 commented Oct 13, 2022

Rebased then rebuilt frontend using npm run build.

Copy link
Collaborator

@lstein lstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I'll merge.

@lstein lstein merged commit ce5e57d into invoke-ai:development Oct 14, 2022
@db3000 db3000 deleted the rename_gfpgan_strength branch October 14, 2022 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants