Generalize facetool strength argument #1078
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take strength for face restoration in the
facetool_strength
parameter everywhere, instead ofgfpgan_strength
. This makes usage of non-GFPGAN face restoration much more straightforward, it never made sense to me that I had to pass--ft codeformer --gfpgan_strength 0.5
to run CodeFormer. The change also makes it easier to add more face restoration algorithms and to expose CodeFormer in the web UI.Mostly just a search and replace, but I left support in for
--gfpgan_strength
as well on the command line and when loading metadata for backwards compatibility.