-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for "1 leaked semaphore objects to clean up at shutdown" on M1 #1081
fix for "1 leaked semaphore objects to clean up at shutdown" on M1 #1081
Conversation
Implements fix by @Any-Winter-4079 referenced in invoke-ai#1016 (comment)
Hi, |
From my testing it looks like h inferring device from x:
|
Okay, should be get h back on the mps as soon as we can (assuming none of the other bits of processing break). I've also noticed that in #1016 up mention the images are not consistent at smaller sizes which concerns me a little, even though I know technically it should be running the same code. Does the new code get triggered at that size where it wasn't before ? |
I have consistent images pre and post patch. But different image than @Any-Winter-4079 with same seed |
@Vargol Any-Winter-4079 just commented, that he copied wrong seed, so images ARE consistent edit: typo |
Yeah, my bad. It was late and I copied the wrong seed haha @Vargol I think
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Implements fix by @Any-Winter-4079 referenced in #1016 (comment)