Make Dockerfile cloud ready (tested on runpod) #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update build-container.yml * add login step to build-container.yml * update job name * update matrix: add registry and platforms also set latest only for cuda image * quote string * use latest for amd and cuda image * separate images for cuda and amd * change latest from auto to true * configure_invoke -y instead of --interactive * fix argument to --yes * update matrix: - use flavor instead of pip-requirements - add flavor `cloud` - add `dockerfile` * introduce INVOKE_MODEL_RECONFIGURE * add `--cap-add=sys_nice` to run.sh * update Dockerfile: install wheel * only have main branch in action again * disable push of cloud image for now since it still has it's own workflow, but PoC succeeded * remove now untrue comments in top
hipsterusername
approved these changes
Dec 12, 2022
|
LGTM but I'd love to see @ebr get eyes on updates as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the
build-container.ymlWorkflow to also push images (@ebr I also already PoC'ed that it would work to push both Dockerfiles with this single Workflow)Also introducing a new env var: INVOKE_MODEL_RECONFIGURE
With this it is possible that the container pulls necesary Model Files without Interaction. If someone wants to alter configuration he has two easy options:
And if someone asks "whats the difference with the cloud image" - well, I think it has a inappropriate name now and should be renamed to "patchmatch". The Difference is that it comes with patchmatch but therfore only works on amd64, while the Dockerfile is at least tested on amd64 and arm64