-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not build Docker images on PR #1933
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@mauwii Could you give this a code-owner review? |
so @lstein: Do we want to get rid of the conda test action, and if yes, should it be Part of this PR? I would recommend, if we refer to conda in the docs, we also make at least sure it is installable. |
I also think concurrency should not be enabled for the container image workflow, when it is only build for main branch pushes at all. This way you would have the ability to choose whichever commit suits you if you do not want to use latest. But in #1950 I updated the |
So far I've updated the documentation to indicate that the conda install method is deprecated and that support will be dropped "in the future." This is in one of the doc PRs I submitted yesterday, not sure if it is merged yet. I would very much like to get rid of the conda CIs, but we can't do it until we officially drop support. I'm not sure about the timing, but I think at least another week in order to avoid alienating developers who have already struggled through the changes in the init file and runtime directory. |
configured to only cancel workflows in PRs, but not on main branch origins in #1933, but opitmized to not cancel workflows of non PRs
I just created a new PR to add the concurrency in the two test workflows, and I set them up in a way that it only will cancel actions in PRs if a new commit comes in, but does not cancel running workflows in a branch (f.E. main), so that it is easier in the end to see where a breaking change was introduced if any slips through (when it would cancel runs in the main branch, they get the red X which will not only mess up the readme (CI Status on main), but also make it impossible to find out when things started to fail). |
configured to only cancel workflows in PRs, but not on main branch origins in #1933, but opitmized to not cancel workflows of non PRs
@mauwii I'm a little unclear on why you needed to create a new PR that straight up duplicates my changes, and then merge it without review... but i guess as long as the code is committed, that's fine by me. |
I did not want to make changes to your PR and since I waited already 2 days for answers, I went ahead and created a separate one. Also this PR is called "Do not build Docker images on PR" which obviously has nothing to do with the two test workflows. And it was merged without review, but I spoke to @blessedcoolant and @lstein beforehand in discord, so I did not just merge what just me thought is good for us all... |
can be closed since cloud-image is not working multiarch and the default Dockerimage already has cloud ability. Will open a new PR to remove uneeded Files and update the docs. |
A few CI optimizations:
latest
)