-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Sliders unable to take typed input #2407
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By and large looks great, but I found a couple of anomaliels:
- In the Unified Canvas, can't type in the text fields for the bounding box width and height.
- Similar problem for "Scaled W" and "Scaled H" in "Infill and Scaling"
- There's no textbox next to the slider for "Inpaint Replace". Also the reset button sets this to 1, rather than the value of 0.1 which is what you get when you first reset the web UI.
These two are intentional. Because it is crucial that the width and height are in multiples of 64, having the user enter arbitrary numbers means we have to constantly calculate the closest resolutions. This can be relatively painful so I disabled manual entry for width and height and let the stepper handle it.
Inpaint replace never had a text box coz of design issues. But those are gone now. I added it and fixed up the default value. |
@lstein Please review this when you get a chance. Thanks. Would like to merge it coz it has a multiple PR build on it. |
I can put this through the ringer and test when I get home today. Sorry for delays - Been a bit busy! 🙃 @keturn - Did we end up removing inpaint replace in diffusers? Should that input just go away, and have the frontend support 1 for img2img strength? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
So far the slider component was unable to take typed input due to a bunch of issues that were a pain to solve. This PR fixes it.
Things to test: