Introduce pre-commit, black, isort, ... #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add feature `content.tabs.link`
- for now only disable `MD046`
- not yet finished
- add flake8-black to dev extras - update `.flake8` - update flake8 pre-commit hook
- better order of hooks - add flake8-comprehensions and flake8-simplify - remove unecesarry hooks which are covered by previous hooks - add hooks - check-executables-have-shebangs - check-shebang-scripts-are-executable
so that default excludes are not overwritten
black: - extend-exclude legacy scripts - config for python 3.9 as long as we support it isort: - set atomic to true to only apply if no syntax errors are introduced - config for python 3.9 as long as we support it - extend_skib_glob legacy scripts - filter_files - match line_length with black - remove_redundant_aliases - skip_gitignore - set src paths - include virtual_env to detect third party modules
additional layer to prevent accidential commits directly to main branch
- disable ul-indent - disable list-marker-space
- this also reformated `docs/index.md`
- prepend brand icons on tabs
- add missing asterisk for backend package - remove old comment
author Kyle Schouviller <kyle0654@hotmail.com> 1669872800 -0800 committer Kyle Schouviller <kyle0654@hotmail.com> 1676240900 -0800 Adding base node architecture Fix type annotation errors Runs and generates, but breaks in saving session Fix default model value setting. Fix deprecation warning. Fixed node api Adding markdown docs Simplifying Generate construction in apps [nodes] A few minor changes (invoke-ai#2510) * Pin api-related requirements * Remove confusing extra CORS origins list * Adds response models for HTTP 200 [nodes] Adding graph_execution_state to soon replace session. Adding tests with pytest. Minor typing fixes [nodes] Fix some small output query hookups [node] Fixing some additional typing issues [nodes] Move and expand graph code. Add base item storage and sqlite implementation. Update startup to match new code [nodes] Add callbacks to item storage [nodes] Adding an InvocationContext object to use for invocations to provide easier extensibility [nodes] New execution model that handles iteration [nodes] Fixing the CLI [nodes] Adding a note to the CLI [nodes] Split processing thread into separate service [node] Add error message on node processing failure Removing old files and duplicated packages Adding python-multipart
Documentation strings are the first thing inside the function body. https://docs.python.org/3/tutorial/controlflow.html#defining-functions
- set `max_line_length = 88` for .py
…ons" This reverts commit 1e7a6dc.
This reverts commit 81fd2ee.
This reverts commit 357601e.
mauwii
requested review from
lstein,
ebr,
blessedcoolant and
tildebyte
as code owners
mauwii
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basically the changes I tried to introduce in #2687 (which could imho be closed then 🙈)