web: allow custom host/port, default to 127.0.0.1 for security reasons #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm only 1 file should have changed, let me see what happened.... |
cgodley
force-pushed
the
web-host-port
branch
from
5925d57
to
68f62c8
Compare
|
Okay should be good to merge now. Sorry about that, still learning how to use GitHub |
bakkot
reviewed
Sep 2, 2022
There was a problem hiding this comment.
Thanks! I'm always a little bit wary of changing the defaults in a way which will make things which used to work stop working, so I'd like to hear opinions from other people about changing the default is a change worth making. But the change to support custom ports is certainly worth it.
Co-authored-by: Kevin Gibbons <bakkot@gmail.com>
Co-authored-by: Kevin Gibbons <bakkot@gmail.com>
|
I'm OK with changing the default behavior as long as we give the user a big fat warning that this has happened. I'm reviewing now, and will add a suitable warning message if the user does not specify --host. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--hostand--portfor the web server to listen on127.0.0.1for security reasons