-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clearing intermediates bug fix #4859
clearing intermediates bug fix #4859
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the PR!
I noticed two issues to be fixed and have made comments for them.
These issues would normally be caught by TypeScript, and you'd have some red squiggly lines under the problematic code. I'm wondering if you don't have a dev environment set up and/or are not getting type hints?
I'm happy to help you get set up if you'd like.
...eai/frontend/web/src/features/system/components/SettingsModal/SettingsClearIntermediates.tsx
Outdated
Show resolved
Hide resolved
...eai/frontend/web/src/features/system/components/SettingsModal/SettingsClearIntermediates.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @martazavro !
I've made a few small changes:
- fixed linting (code format) issues
- disabled the
Clear Intermediates
button when the queue has pending items - add a tooltip to
Clear Intermediates
button when its disabled
Thank you so much @psychedelicious ! |
What type of PR is this? (check all applicable)
Related Tickets & Documents