clearing intermediates bug fix #4859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martazavro
requested review from
psychedelicious,
blessedcoolant,
maryhipp and
hipsterusername
as code owners
psychedelicious
requested changes
Oct 12, 2023
There was a problem hiding this comment.
Hi, thanks for the PR!
I noticed two issues to be fixed and have made comments for them.
These issues would normally be caught by TypeScript, and you'd have some red squiggly lines under the problematic code. I'm wondering if you don't have a dev environment set up and/or are not getting type hints?
I'm happy to help you get set up if you'd like.
...eai/frontend/web/src/features/system/components/SettingsModal/SettingsClearIntermediates.tsx
Outdated
Show resolved
Hide resolved
...eai/frontend/web/src/features/system/components/SettingsModal/SettingsClearIntermediates.tsx
Show resolved
Hide resolved
psychedelicious
approved these changes
Oct 15, 2023
There was a problem hiding this comment.
Thanks @martazavro !
I've made a few small changes:
- fixed linting (code format) issues
- disabled the
Clear Intermediatesbutton when the queue has pending items - add a tooltip to
Clear Intermediatesbutton when its disabled
Thank you so much @psychedelicious ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Tickets & Documents