ui: redesign followups 2 #5374
Merged
ui: redesign followups 2 #5374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
accidentally hid it from everywhere
- Fix `weight` and `begin_step_percent`, the constraints were mixed up - Add model validatort to ensure `begin_step_percent < end_step_percent` - Bump version
Required some rejiggering of the InvControl and InvSlider styles.
Canvas and non-canvas have separate width and height and need their own separate aspect ratios. In order to not duplicate a lot of aspect ratio logic, the components relating to image size have been modularized.
- Support grid size of 8 on canvas - Internal canvas math works on 8 - Update gridlines rendering to show 64 spaced lines and 32/16/8 when zoomed in - Bbox manipulation defaults to grid of 64 - hold shift to get grid of 8 Besides being something we support internally, supporting 8 on canvas avoids a lot of hacky logic needed to work well with aspect ratios.
Making the math match the previous implementation
- Prompt must have an open curly brace followed by a close curly brace to enable dynamic prompts processing - If a the given prompt already had a dynamic prompt cached, do not re-process - If processing is not needed, user may invoke immediately - Invoke button shows loading state when dynamic prompts are processing, tooltip says generating - Dynamic prompts preview icon in prompt box shows loading state when processing, tooltip says generating
not working yet WIP
psychedelicious
requested review from
blessedcoolant,
maryhipp,
hipsterusername,
Kyle0654 and
brandonrising
as code owners
hipsterusername
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
Misc fixes:
Canvas fixes:
Dynamic prompts UX:
QA Instructions, Screenshots, Recordings
Try out canvas and dynamic prompts interactions.
Merge Plan
This can be merged when approved.
Added/updated tests?