tidy(mm): ModelSearch cleanup #5912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
lstein,
blessedcoolant,
GreggHelt2,
brandonrising,
RyanJDick and
hipsterusername
as code owners
psychedelicious
force-pushed
the
psyche/tidy/tidy-model-search
branch
from
8f5f4c8
to
bd10357
Compare
github-actions
bot
added
python
hipsterusername
approved these changes
Mar 9, 2024
hipsterusername
force-pushed
the
psyche/tidy/tidy-model-search
branch
from
bd10357
to
8d40b25
Compare
- No need for it to by a pydantic model. Just a class now. - Remove ABC, it made it hard to understand what was going on as attributes were spread across the ABC and implementation. Also, there is no other implementation. - Add tests
- `config` is unused - `stats` is created on instantiation - `logger` uses the app logger
- Use `set` instead of `Set` - Methods accept only `Path`s
psychedelicious
force-pushed
the
psyche/tidy/tidy-model-search
branch
from
f0492d9
to
1a26454
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
QA Instructions, Screenshots, Recordings
You should have the same models imported at startup as on
main(using a memory db).Tests offer solid coverage, too.
Merge Plan
This PR can be merged when approved
Added/updated tests?
have not been included