Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidy(mm): ModelSearch cleanup #5912

Merged
merged 5 commits into from
Mar 10, 2024
Merged

tidy(mm): ModelSearch cleanup #5912

merged 5 commits into from
Mar 10, 2024

Commits on Mar 10, 2024

  1. tidy(mm): ModelSearch cleanup 

    - No need for it to by a pydantic model. Just a class now.
- Remove ABC, it made it hard to understand what was going on as attributes were spread across the ABC and implementation. Also, there is no other implementation.
- Add tests
    @psychedelicious
    psychedelicious committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    690b1c2 View commit details
    Browse the repository at this point in the history

  2. tidy(mm): remove extraneous dependencies in model search 

    - `config` is unused
- `stats` is created on instantiation
- `logger` uses the app logger
    @psychedelicious
    psychedelicious committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    4fd2fb2 View commit details
    Browse the repository at this point in the history

  3. docs(mm): update docstrings for ModelSearch

    @psychedelicious
    psychedelicious committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    a50d234 View commit details
    Browse the repository at this point in the history

  4. tidy(mm): simplify types for ModelSearch 

    - Use `set` instead of `Set`
- Methods accept only `Path`s
    @psychedelicious
    psychedelicious committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    5280225 View commit details
    Browse the repository at this point in the history

  5. docs(mm): format docstrings for ModelSearch

    @psychedelicious
    psychedelicious committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    1a26454 View commit details
    Browse the repository at this point in the history