Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): connection validation rework #6386

Merged
merged 55 commits into from
May 19, 2024
Merged

feat(ui): connection validation rework #6386

merged 55 commits into from
May 19, 2024

Commits on May 19, 2024

  1. feat(ui): add originalType to FieldType, improved connection valida… 

    …tion

We now keep track of the original field type, derived from the python type annotation in addition to the override type provided by `ui_type`.

This makes `ui_type` work more like it sound like it should work - change the UI input component only.

Connection validation is extend to also check the original types. If there is any match between two fields' "final" or original types, we consider the connection valid.This change is backwards-compatible; there is no workflow migration needed.
    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    c54fe01 View commit details
    Browse the repository at this point in the history

  2. feat(nodes): make all ModelIdentifierField inputs accept connections

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    d8000fd View commit details
    Browse the repository at this point in the history

  3. fix(ui): stupid ts

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    79cebb9 View commit details
    Browse the repository at this point in the history

  4. fix(ui): do not allow comparison between undefined original types

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    df7cdc1 View commit details
    Browse the repository at this point in the history

  5. feat(ui): add ModelIdentifierField field type 

    This new field type accepts _any_ model. A field renderer lets the user select any available model.
    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    8c04641 View commit details
    Browse the repository at this point in the history

  6. feat(nodes): add ModelIdentifierInvocation 

    This node allows a user to select _any_ model, outputting a `ModelIdentifierField` for that model.
    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    a8b9c75 View commit details
    Browse the repository at this point in the history

  7. fix(ui): rebase resolution

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    f6f83af View commit details
    Browse the repository at this point in the history

  8. chore(ui): lint

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    0b4bf72 View commit details
    Browse the repository at this point in the history

  9. tidy(ui): tidy connection validation functions and logic

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    1eff66a View commit details
    Browse the repository at this point in the history

  10. feat(ui): makeConnectionErrorSelector now creates a parameterized sel… 

    …ector
    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    0d45d1b View commit details
    Browse the repository at this point in the history

  11. fix(ui): rebase conflict

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    677c37f View commit details
    Browse the repository at this point in the history

  12. tidy(ui): clean up addnodepopover hotkeys

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    1a339e3 View commit details
    Browse the repository at this point in the history

  13. fix(ui): rework edge update logic

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    ce0b0e5 View commit details
    Browse the repository at this point in the history

  14. fix(ui): call updateNodeInternals when making connections

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    ceabd9a View commit details
    Browse the repository at this point in the history

  15. tests(ui): add tests for consolidated connection validation

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    92b74ad View commit details
    Browse the repository at this point in the history

  16. tests(ui): finish test cases for validateConnection

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    9878224 View commit details
    Browse the repository at this point in the history

  17. tidy(ui): areTypesEqual var names

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    503abf5 View commit details
    Browse the repository at this point in the history

  18. tidy(ui): validateConnection code clarity

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    c0eff8f View commit details
    Browse the repository at this point in the history

  19. tests(ui): coverage for validateConnectionTypes

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    da8db49 View commit details
    Browse the repository at this point in the history

  20. tests(ui): coverage for getCollectItemType

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    0baff06 View commit details
    Browse the repository at this point in the history

  21. tests(ui): add iterate to test schema

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    c18938c View commit details
    Browse the repository at this point in the history

  22. feat(ui): better types for validateConnection

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    9637cc3 View commit details
    Browse the repository at this point in the history

  23. feat(ui): add strict mode to validateConnection

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    d2093ef View commit details
    Browse the repository at this point in the history

  24. feat(ui): use new validateConnection

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    4fe32f4 View commit details
    Browse the repository at this point in the history

  25. fix(ui): handling for in-progress edge updates during conection valid… 

    …ation
    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    1a3431f View commit details
    Browse the repository at this point in the history

  26. tidy(ui): extraneous vars in makeConnectionErrorSelector

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    67f2461 View commit details
    Browse the repository at this point in the history

  27. tests(ui): add buildNode convenience wrapper for buildInvocationNode

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    ec99d72 View commit details
    Browse the repository at this point in the history

  28. feat(ui): extract logic for finding candidate fields to own function

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    2d35d0f View commit details
    Browse the repository at this point in the history

  29. tests(ui): candidate fields, getFirstValidConnection (wip)

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    87a5216 View commit details
    Browse the repository at this point in the history

  30. feat(ui): rework getFirstValidConnection with new helpers

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    0271c9b View commit details
    Browse the repository at this point in the history

  31. tests(ui): coverage for getFirstValidConnection

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    e1ec42f View commit details
    Browse the repository at this point in the history

  32. tests(ui): coverage for getCollectItemType

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    da1dd71 View commit details
    Browse the repository at this point in the history

  33. feat(ui): rework pendingConnection

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    9d01282 View commit details
    Browse the repository at this point in the history

  34. chore(ui): knip

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    c70392d View commit details
    Browse the repository at this point in the history

  35. fix(ui): duplicated edges when updating edge with lazy connect

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    75ec910 View commit details
    Browse the repository at this point in the history

  36. feat(ui): rework node and edge mutation logic 

    Remove our DIY'd reducers, consolidating all node and edge mutations to use `edgesChanged` and `nodesChanged`, which are called by reactflow. This makes the API for manipulating nodes and edges less tangly and error-prone.
    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    838bff9 View commit details
    Browse the repository at this point in the history

  37. fix(ui): edge styling

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    338bb39 View commit details
    Browse the repository at this point in the history

  38. fix(ui): collapsed edges selected state

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    c1ec9d9 View commit details
    Browse the repository at this point in the history

  39. feat(ui): tweak edge styling

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    5775db8 View commit details
    Browse the repository at this point in the history

  40. feat(ui): get rid of nodeAdded

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    ff99fd2 View commit details
    Browse the repository at this point in the history

  41. fix(ui): group edge selection actions

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    fea1305 View commit details
    Browse the repository at this point in the history

  42. feat(ui): remove nodeReplaced action

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    7257f1f View commit details
    Browse the repository at this point in the history

  43. feat(ui): remove selectedAll action

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    bcb8df9 View commit details
    Browse the repository at this point in the history

  44. feat(ui): remove selectionPasted action

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    0343f32 View commit details
    Browse the repository at this point in the history

  45. feat(ui): remove selectionDeleted action

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    5bb3239 View commit details
    Browse the repository at this point in the history

  46. tidy(ui): more succinct syntax for edge and node updates

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    0362026 View commit details
    Browse the repository at this point in the history

  47. feat(ui): remove nodeExclusivelySelected action

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    ed7aac9 View commit details
    Browse the repository at this point in the history

  48. fix(ui): do not remove exposed fields when updating workflows

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    8888455 View commit details
    Browse the repository at this point in the history

  49. perf(ui): ignore all no-op node and edge changes

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    0fe0640 View commit details
    Browse the repository at this point in the history

  50. fix(ui): set nodeDragThreshold to prevent spurious position change ev… 

    …ents
    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    1fefe3b View commit details
    Browse the repository at this point in the history

  51. feat(ui): use connection validationResults directly in components

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    0490383 View commit details
    Browse the repository at this point in the history

  52. perf(ui): memoize WorkflowName selectors

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    16c59fe View commit details
    Browse the repository at this point in the history

  53. feat(nodes): make ModelIdentifierInvocation a prototype

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    dde1725 View commit details
    Browse the repository at this point in the history

  54. fix(ui): delete edges when their source or target no longer exists

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    dae60bb View commit details
    Browse the repository at this point in the history

  55. fix(ui): missed node execution state for progress images

    @psychedelicious
    psychedelicious committed May 19, 2024
    Configuration menu
    Copy the full SHA
    31d43cc View commit details
    Browse the repository at this point in the history