Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkboxes #18

Closed
io7m opened this issue Jul 20, 2016 · 0 comments
Closed

Checkboxes #18

io7m opened this issue Jul 20, 2016 · 0 comments

Comments

@io7m
Copy link
Member

io7m commented Jul 20, 2016

Buttons that stay pressed when pressed, and then become un-pressed when pressed again.

@io7m io7m self-assigned this Jul 20, 2016
@io7m io7m changed the title Radio buttons Checkboxes Jul 20, 2016
@io7m io7m mentioned this issue Jul 20, 2016
io7m added a commit that referenced this issue Jul 23, 2016
This splits the original button type into Repeatable and Checkbox
variants, both of which are of type SyButtonType. Both may be
themed separately. This also changes the component-internal
windowTheme() function into one that's now total instead of
raising IllegalStateException if the component is not attached to
a window. Consequently, components are now more likely to do the
correct thing if they have logic that's theme dependent.  This is
true of checkboxes: When pressed, they add a theme-specific image as
a child node to display a checkbox. They cannot do this if they are
not attached to a window, because then there is no theme.

Add a theme listener interface to help implement components that
need to perform actions when the theme changes.

Add more tests for semantics and improve logging efficiency by
adding braces.

Fix #18
Fix #11
@io7m io7m closed this as completed Jul 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant