Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move line numbers out of measured lines #48

Closed
io7m opened this issue Dec 8, 2023 · 1 comment
Closed

Move line numbers out of measured lines #48

io7m opened this issue Dec 8, 2023 · 1 comment

Comments

@io7m
Copy link
Member

io7m commented Dec 8, 2023

Bounds in a measured line should be returned in text-local space (not parent-relative space).

Line numbers should be moved out of the measured line data structure.

With these two changes, text models can avoid recalculating measured lines just because some earlier text section was changed and now all of the line numbers are incorrect. Line numbers should be a property of the structures storing the measured lines, not the measured lines themselves.

@io7m io7m self-assigned this Dec 8, 2023
io7m added a commit that referenced this issue Dec 9, 2023
io7m added a commit that referenced this issue Dec 9, 2023
io7m added a commit that referenced this issue Dec 13, 2023
Affects: #48
Affects: #14
@io7m
Copy link
Member Author

io7m commented Dec 13, 2023

Done.

@io7m io7m closed this as completed Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant