New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using terms like width and height #11

Closed
io7m opened this Issue May 7, 2017 · 2 comments

Comments

Projects
None yet
1 participant
@io7m
Owner

io7m commented May 7, 2017

This ascribes meaning to axes that programmers using jregions may not be using.

width -> sizeX
height -> sizeY
depth -> sizeZ

Removes any possibility of ambiguity.

@io7m io7m added the enhancement label May 7, 2017

@io7m io7m self-assigned this May 7, 2017

io7m added a commit that referenced this issue May 7, 2017

Initial basic volume API
This adds functions and types for dealing with volumes. The API
is not yet as complete as that provided for areas.

Affects #11
Affects #9
@io7m

This comment has been minimized.

Show comment
Hide comment
@io7m

io7m May 7, 2017

Owner

This also includes terms like "horizontally" and "vertically".

Owner

io7m commented May 7, 2017

This also includes terms like "horizontally" and "vertically".

io7m added a commit that referenced this issue May 7, 2017

Stop using ambiguous terms
Stop using terms such as "horizontally", "vertically", "width",
"height", etc. Deprecate methods and add replacements.

Affects #11

@io7m io7m modified the milestone: 1.1.0 May 7, 2017

io7m added a commit that referenced this issue May 7, 2017

io7m added a commit that referenced this issue May 8, 2017

Avoid using the terms "width" and "height"
This removes the final uses of "width" and "height" from the code
and introduces binary-compatible deprecated methods to be removed in
a future release.

Affects #11
@io7m

This comment has been minimized.

Show comment
Hide comment
@io7m

io7m May 8, 2017

Owner

Done.

Owner

io7m commented May 8, 2017

Done.

@io7m io7m closed this May 8, 2017

io7m added a commit that referenced this issue May 9, 2017

Merge branch 'release/1.1.0'
Release: com.io7m.jregions 1.1.0
Code new: Add splitAlongXY method for dividing areas into quadrants.
Code new: Stop using terms such as "horizontally", "vertically", "width", "height", etc. Deprecate methods and add replacements. (tickets: #11)
Code new: Add volume types. (tickets: #9)
Code fix: Fix overlaps() for areas and volumes. (tickets: #12, #14)
Code fix: Fix contains() for areas and volumes. (tickets: #13)

io7m added a commit that referenced this issue May 9, 2017

Merge tag 'com.io7m.jregions-1.1.0' into develop
Release: com.io7m.jregions 1.1.0

Code new: Add splitAlongXY method for dividing areas into quadrants.
Code new: Stop using terms such as "horizontally", "vertically", "width", "height", etc. Deprecate methods and add replacements. (tickets: #11)
Code new: Add volume types. (tickets: #9)
Code fix: Fix overlaps() for areas and volumes. (tickets: #12, #14)
Code fix: Fix contains() for areas and volumes. (tickets: #13)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment