Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using terms like width and height #11

Closed
io7m opened this issue May 7, 2017 · 2 comments
Closed

Stop using terms like width and height #11

io7m opened this issue May 7, 2017 · 2 comments
Assignees
@io7m
Labels
enhancement
Milestone
1.1.0

Comments

@io7m
Copy link
Owner

io7m commented May 7, 2017

This ascribes meaning to axes that programmers using jregions may not be using.

width -> sizeX
height -> sizeY
depth -> sizeZ

Removes any possibility of ambiguity.
@io7m io7m self-assigned this May 7, 2017
io7m added a commit that referenced this issue May 7, 2017
@io7m
Initial basic volume API
3b747d6 
This adds functions and types for dealing with volumes. The API
is not yet as complete as that provided for areas.

Affects #11
Affects #9
@io7m
Copy link
Owner Author

io7m commented May 7, 2017

This also includes terms like "horizontally" and "vertically".

io7m added a commit that referenced this issue May 7, 2017
@io7m
Stop using ambiguous terms
3987521 
Stop using terms such as "horizontally", "vertically", "width",
"height", etc. Deprecate methods and add replacements.

Affects #11
@io7m io7m modified the milestone: 1.1.0 May 7, 2017
io7m added a commit that referenced this issue May 7, 2017
@io7m
Avoid using the terms "width" and "height"
73471e1 
Affects #11
io7m added a commit that referenced this issue May 8, 2017
@io7m
Avoid using the terms "width" and "height"
dd4cbe9 
This removes the final uses of "width" and "height" from the code
and introduces binary-compatible deprecated methods to be removed in
a future release.

Affects #11
@io7m
Copy link
Owner Author

io7m commented May 8, 2017

Done.

@io7m io7m closed this as completed May 8, 2017
io7m added a commit that referenced this issue May 9, 2017
@io7m
Merge branch 'release/1.1.0'
dd8029a 
Release: com.io7m.jregions 1.1.0
Code new: Add splitAlongXY method for dividing areas into quadrants.
Code new: Stop using terms such as "horizontally", "vertically", "width", "height", etc. Deprecate methods and add replacements. (tickets: #11)
Code new: Add volume types. (tickets: #9)
Code fix: Fix overlaps() for areas and volumes. (tickets: #12, #14)
Code fix: Fix contains() for areas and volumes. (tickets: #13)
io7m added a commit that referenced this issue May 9, 2017
@io7m
Merge tag 'com.io7m.jregions-1.1.0' into develop
6cfc0f7 
Release: com.io7m.jregions 1.1.0

Code new: Add splitAlongXY method for dividing areas into quadrants.
Code new: Stop using terms such as "horizontally", "vertically", "width", "height", etc. Deprecate methods and add replacements. (tickets: #11)
Code new: Add volume types. (tickets: #9)
Code fix: Fix overlaps() for areas and volumes. (tickets: #12, #14)
Code fix: Fix contains() for areas and volumes. (tickets: #13)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@io7m io7m

Labels
enhancement
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
1 participant
@io7m