Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlaps() is incorrect #12

Closed
io7m opened this issue May 8, 2017 · 0 comments
Closed

Overlaps() is incorrect #12

io7m opened this issue May 8, 2017 · 0 comments
Assignees
@io7m
Labels
bug
Milestone
1.1.0

Comments

@io7m
Copy link
Member

io7m commented May 8, 2017

Right now, an area {minimumX=0, maximumX=10, minimumY=0, maximumY=10} is considered to overlap an area {minimumX=10, maximumX=20, minimumY=10, maximumY=20}. This is incorrect! maximumX and maximumY are exclusive upper bounds.
@io7m io7m added the bug label May 8, 2017
@io7m io7m added this to the 1.1.0 milestone May 8, 2017
@io7m io7m self-assigned this May 8, 2017
@io7m io7m closed this as completed in fa93b60 May 8, 2017
@io7m io7m mentioned this issue May 8, 2017
Closed
io7m added a commit that referenced this issue May 9, 2017
@io7m
Merge branch 'release/1.1.0'
dd8029a 
Release: com.io7m.jregions 1.1.0
Code new: Add splitAlongXY method for dividing areas into quadrants.
Code new: Stop using terms such as "horizontally", "vertically", "width", "height", etc. Deprecate methods and add replacements. (tickets: #11)
Code new: Add volume types. (tickets: #9)
Code fix: Fix overlaps() for areas and volumes. (tickets: #12, #14)
Code fix: Fix contains() for areas and volumes. (tickets: #13)
io7m added a commit that referenced this issue May 9, 2017
@io7m
Merge tag 'com.io7m.jregions-1.1.0' into develop
6cfc0f7 
Release: com.io7m.jregions 1.1.0

Code new: Add splitAlongXY method for dividing areas into quadrants.
Code new: Stop using terms such as "horizontally", "vertically", "width", "height", etc. Deprecate methods and add replacements. (tickets: #11)
Code new: Add volume types. (tickets: #9)
Code fix: Fix overlaps() for areas and volumes. (tickets: #12, #14)
Code fix: Fix contains() for areas and volumes. (tickets: #13)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@io7m io7m

Labels
bug
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
1 participant
@io7m