Overlaps() is incorrect #12
Comments
Closed
io7m
added a commit
that referenced
this issue
May 9, 2017
Release: com.io7m.jregions 1.1.0 Code new: Add splitAlongXY method for dividing areas into quadrants. Code new: Stop using terms such as "horizontally", "vertically", "width", "height", etc. Deprecate methods and add replacements. (tickets: #11) Code new: Add volume types. (tickets: #9) Code fix: Fix overlaps() for areas and volumes. (tickets: #12, #14) Code fix: Fix contains() for areas and volumes. (tickets: #13)
io7m
added a commit
that referenced
this issue
May 9, 2017
Release: com.io7m.jregions 1.1.0 Code new: Add splitAlongXY method for dividing areas into quadrants. Code new: Stop using terms such as "horizontally", "vertically", "width", "height", etc. Deprecate methods and add replacements. (tickets: #11) Code new: Add volume types. (tickets: #9) Code fix: Fix overlaps() for areas and volumes. (tickets: #12, #14) Code fix: Fix contains() for areas and volumes. (tickets: #13)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now, an area
{minimumX=0, maximumX=10, minimumY=0, maximumY=10}is considered to overlap an area{minimumX=10, maximumX=20, minimumY=10, maximumY=20}. This is incorrect!maximumXandmaximumYare exclusive upper bounds.The text was updated successfully, but these errors were encountered: