New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
started adapter.ts port #1917
started adapter.ts port #1917
Conversation
foxriver76
commented
May 11, 2022
•
edited
edited
- closes Add decrypt value guard #1861
- closes Keep /doc in Repository up to date #1334
This pull request introduces 1 alert when merging f639981 into 86c4e79 - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts and fixes 1 when merging bd49013 into 90b9f0e - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 2 alerts and fixes 1 when merging bddc8ca into 90b9f0e - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 2 alerts and fixes 1 when merging 151051f into 90b9f0e - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 2 alerts and fixes 1 when merging 875f032 into 90b9f0e - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 4 alerts and fixes 1 when merging ac7d568 into 90b9f0e - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 2 alerts and fixes 1 when merging 138d0cf into 90b9f0e - view on LGTM.com new alerts:
fixed alerts:
|
7a0839c
to
3b09770
Compare
This pull request introduces 2 alerts and fixes 1 when merging a699fbd into 1fe5a1e - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 3 alerts and fixes 1 when merging 537046a into 1fe5a1e - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 2 alerts and fixes 1 when merging fc935de into 1fe5a1e - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 2 alerts and fixes 1 when merging 7e5707c into 1fe5a1e - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 2 alerts and fixes 1 when merging 90506ef into 1fe5a1e - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 2 alerts and fixes 3 when merging 695e3cd into 0de381d - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 2 alerts and fixes 3 when merging f063f46 into 0de381d - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 2 alerts and fixes 3 when merging fe2576b into 0de381d - view on LGTM.com new alerts:
fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About the rest: most of this seems to be the same as before, but in a different color so to speak. I think it's fine to merge that and do type polishing later.
I did find a couple of : any
though which I don't like.
- Method implementations like
async setForeignState(id: any, state: any, ack: any, options?: any, callback?: any)
- these should probably beunknown
like most of the other signatures. idToDCS(id: any)
- Again, should beunknown
and checked if it is actually a string.- etc.
Most of them don't check their arguments yet like the unknown
variants do.
This pull request introduces 2 alerts and fixes 3 when merging a74c68f into 0de381d - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 2 alerts and fixes 3 when merging 8ffee39 into 0de381d - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 2 alerts and fixes 3 when merging 90584cd into 0de381d - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 3 alerts and fixes 3 when merging 12fdbae into 0de381d - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 3 alerts and fixes 3 when merging 35f1eaa into 0de381d - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 3 alerts and fixes 3 when merging 127e041 into dc10033 - view on LGTM.com new alerts:
fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two things
ready to merge @Apollon77 |
This pull request introduces 3 alerts and fixes 3 when merging d2a01bf into dc10033 - view on LGTM.com new alerts:
fixed alerts:
|
So guys, here we go |