Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

started adapter.ts port #1917

Merged
merged 61 commits into from Aug 26, 2022
Merged

started adapter.ts port #1917

merged 61 commits into from Aug 26, 2022

Conversation

foxriver76
Copy link
Collaborator

@foxriver76 foxriver76 commented May 11, 2022

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 11, 2022

This pull request introduces 1 alert when merging f639981 into 86c4e79 - view on LGTM.com

new alerts:

  • 1 for Clear-text logging of sensitive information

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 12, 2022

This pull request introduces 2 alerts and fixes 1 when merging bd49013 into 90b9f0e - view on LGTM.com

new alerts:

  • 1 for Clear-text logging of sensitive information
  • 1 for Incomplete string escaping or encoding

fixed alerts:

  • 1 for Incomplete string escaping or encoding

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 12, 2022

This pull request introduces 2 alerts and fixes 1 when merging bddc8ca into 90b9f0e - view on LGTM.com

new alerts:

  • 1 for Clear-text logging of sensitive information
  • 1 for Incomplete string escaping or encoding

fixed alerts:

  • 1 for Incomplete string escaping or encoding

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 13, 2022

This pull request introduces 2 alerts and fixes 1 when merging 151051f into 90b9f0e - view on LGTM.com

new alerts:

  • 1 for Clear-text logging of sensitive information
  • 1 for Incomplete string escaping or encoding

fixed alerts:

  • 1 for Incomplete string escaping or encoding

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 16, 2022

This pull request introduces 2 alerts and fixes 1 when merging 875f032 into 90b9f0e - view on LGTM.com

new alerts:

  • 1 for Clear-text logging of sensitive information
  • 1 for Incomplete string escaping or encoding

fixed alerts:

  • 1 for Incomplete string escaping or encoding

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 16, 2022

This pull request introduces 4 alerts and fixes 1 when merging ac7d568 into 90b9f0e - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class
  • 1 for Clear-text logging of sensitive information
  • 1 for Incomplete string escaping or encoding

fixed alerts:

  • 1 for Incomplete string escaping or encoding

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 16, 2022

This pull request introduces 2 alerts and fixes 1 when merging 138d0cf into 90b9f0e - view on LGTM.com

new alerts:

  • 1 for Clear-text logging of sensitive information
  • 1 for Incomplete string escaping or encoding

fixed alerts:

  • 1 for Incomplete string escaping or encoding

@foxriver76 foxriver76 force-pushed the master branch 3 times, most recently from 7a0839c to 3b09770 Compare May 16, 2022 14:17
@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 17, 2022

This pull request introduces 2 alerts and fixes 1 when merging a699fbd into 1fe5a1e - view on LGTM.com

new alerts:

  • 1 for Clear-text logging of sensitive information
  • 1 for Incomplete string escaping or encoding

fixed alerts:

  • 1 for Incomplete string escaping or encoding

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 17, 2022

This pull request introduces 3 alerts and fixes 1 when merging 537046a into 1fe5a1e - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class
  • 1 for Clear-text logging of sensitive information
  • 1 for Incomplete string escaping or encoding

fixed alerts:

  • 1 for Incomplete string escaping or encoding

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 17, 2022

This pull request introduces 2 alerts and fixes 1 when merging fc935de into 1fe5a1e - view on LGTM.com

new alerts:

  • 1 for Clear-text logging of sensitive information
  • 1 for Incomplete string escaping or encoding

fixed alerts:

  • 1 for Incomplete string escaping or encoding

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 17, 2022

This pull request introduces 2 alerts and fixes 1 when merging 7e5707c into 1fe5a1e - view on LGTM.com

new alerts:

  • 1 for Clear-text logging of sensitive information
  • 1 for Incomplete string escaping or encoding

fixed alerts:

  • 1 for Incomplete string escaping or encoding

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 17, 2022

This pull request introduces 2 alerts and fixes 1 when merging 90506ef into 1fe5a1e - view on LGTM.com

new alerts:

  • 1 for Clear-text logging of sensitive information
  • 1 for Incomplete string escaping or encoding

fixed alerts:

  • 1 for Incomplete string escaping or encoding

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Aug 8, 2022

This pull request introduces 2 alerts and fixes 3 when merging 695e3cd into 0de381d - view on LGTM.com

new alerts:

  • 1 for Clear-text logging of sensitive information
  • 1 for Incomplete string escaping or encoding

fixed alerts:

  • 2 for Useless conditional
  • 1 for Incomplete string escaping or encoding

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Aug 8, 2022

This pull request introduces 2 alerts and fixes 3 when merging f063f46 into 0de381d - view on LGTM.com

new alerts:

  • 1 for Clear-text logging of sensitive information
  • 1 for Incomplete string escaping or encoding

fixed alerts:

  • 2 for Useless conditional
  • 1 for Incomplete string escaping or encoding

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Aug 9, 2022

This pull request introduces 2 alerts and fixes 3 when merging fe2576b into 0de381d - view on LGTM.com

new alerts:

  • 1 for Clear-text logging of sensitive information
  • 1 for Incomplete string escaping or encoding

fixed alerts:

  • 2 for Useless conditional
  • 1 for Incomplete string escaping or encoding

Copy link
Collaborator

@AlCalzone AlCalzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About the rest: most of this seems to be the same as before, but in a different color so to speak. I think it's fine to merge that and do type polishing later.

I did find a couple of : any though which I don't like.

  • Method implementations like async setForeignState(id: any, state: any, ack: any, options?: any, callback?: any) - these should probably be unknown like most of the other signatures.
  • idToDCS(id: any) - Again, should be unknown and checked if it is actually a string.
  • etc.

Most of them don't check their arguments yet like the unknown variants do.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Aug 10, 2022

This pull request introduces 2 alerts and fixes 3 when merging a74c68f into 0de381d - view on LGTM.com

new alerts:

  • 1 for Clear-text logging of sensitive information
  • 1 for Incomplete string escaping or encoding

fixed alerts:

  • 2 for Useless conditional
  • 1 for Incomplete string escaping or encoding

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Aug 10, 2022

This pull request introduces 2 alerts and fixes 3 when merging 8ffee39 into 0de381d - view on LGTM.com

new alerts:

  • 1 for Clear-text logging of sensitive information
  • 1 for Incomplete string escaping or encoding

fixed alerts:

  • 2 for Useless conditional
  • 1 for Incomplete string escaping or encoding

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Aug 10, 2022

This pull request introduces 2 alerts and fixes 3 when merging 90584cd into 0de381d - view on LGTM.com

new alerts:

  • 1 for Clear-text logging of sensitive information
  • 1 for Incomplete string escaping or encoding

fixed alerts:

  • 2 for Useless conditional
  • 1 for Incomplete string escaping or encoding

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Aug 11, 2022

This pull request introduces 3 alerts and fixes 3 when merging 12fdbae into 0de381d - view on LGTM.com

new alerts:

  • 1 for Unreachable method overloads
  • 1 for Clear-text logging of sensitive information
  • 1 for Incomplete string escaping or encoding

fixed alerts:

  • 2 for Useless conditional
  • 1 for Incomplete string escaping or encoding

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Aug 11, 2022

This pull request introduces 3 alerts and fixes 3 when merging 35f1eaa into 0de381d - view on LGTM.com

new alerts:

  • 1 for Unreachable method overloads
  • 1 for Clear-text logging of sensitive information
  • 1 for Incomplete string escaping or encoding

fixed alerts:

  • 2 for Useless conditional
  • 1 for Incomplete string escaping or encoding

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Aug 24, 2022

This pull request introduces 3 alerts and fixes 3 when merging 127e041 into dc10033 - view on LGTM.com

new alerts:

  • 1 for Unreachable method overloads
  • 1 for Clear-text logging of sensitive information
  • 1 for Incomplete string escaping or encoding

fixed alerts:

  • 2 for Useless conditional
  • 1 for Incomplete string escaping or encoding

Copy link
Collaborator

@AlCalzone AlCalzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two things

packages/adapter/src/lib/_Types.ts Outdated Show resolved Hide resolved
packages/adapter/src/lib/_Types.ts Outdated Show resolved Hide resolved
@foxriver76
Copy link
Collaborator Author

ready to merge @Apollon77

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Aug 24, 2022

This pull request introduces 3 alerts and fixes 3 when merging d2a01bf into dc10033 - view on LGTM.com

new alerts:

  • 1 for Unreachable method overloads
  • 1 for Clear-text logging of sensitive information
  • 1 for Incomplete string escaping or encoding

fixed alerts:

  • 2 for Useless conditional
  • 1 for Incomplete string escaping or encoding

@Apollon77 Apollon77 added this to In progress in Next version 4.1 (...) via automation Aug 26, 2022
@Apollon77
Copy link
Collaborator

So guys, here we go

@Apollon77 Apollon77 merged commit d2cf6a0 into master Aug 26, 2022
@Apollon77 Apollon77 deleted the adapter-ts branch August 26, 2022 17:55
Next version 4.1 (...) automation moved this from In progress to Done Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Add decrypt value guard Keep /doc in Repository up to date
4 participants