Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent issue when values with stateNs.null exist in the database #2580

Merged
merged 9 commits into from
Jan 28, 2024

Conversation

foxriver76
Copy link
Collaborator

@foxriver76 foxriver76 commented Jan 10, 2024

Problem:

  • with the high speed optimization on alias getStates, we use a single MGET instead of multiple GET commands
  • this lead to the DB still trying to get null values if present in the list, but no chance to filter out manually

Solution:

  • with the new approach we are really just requesting the states which are not null ids and putting them in the correct place of in the array afterwards, which should further optimize performance in some cases

…orrect build script when building dependency packages

- and using normal workspace flag works but is ineffective and can lead to errors due to still open npm/rfcs#548
@foxriver76 foxriver76 merged commit 1906f86 into master Jan 28, 2024
14 checks passed
@foxriver76 foxriver76 deleted the issue-2579 branch January 28, 2024 20:57
foxriver76 added a commit that referenced this pull request Jan 28, 2024
)

* prevent issue when values with stateNs.null exist in the database

- closes #2579

* rm log

* rm anoither log

* allow path aliases in adapter package

* rm types from validator again

* move tsc-alias to postbuild

* use lerna to build project again as npm workspaces does not use the correct build script when building dependency packages

- and using normal workspace flag works but is ineffective and can lead to errors due to still open npm/rfcs#548

* update jsonl
foxriver76 added a commit that referenced this pull request Jan 29, 2024
* optimize the upload procedure (#2589)

- closes #2538

* fixed problem that cb is never called on mh enable/disable (#2557)

* fixed problem that cb is never called on mh enable/disable

* fix type

* added enhanced adapter license info to schema and types (#2591)

* added license info

* fix update license script

* format

* deprecate common.license and introduce common.licenseInformation

* rm local schema from controller iopack

* bring back license for adapter tests

* WIP placeholder added

* prevent issue when values with stateNs.null exist in the database (#2580)

* prevent issue when values with stateNs.null exist in the database

- closes #2579

* rm log

* rm anoither log

* allow path aliases in adapter package

* rm types from validator again

* move tsc-alias to postbuild

* use lerna to build project again as npm workspaces does not use the correct build script when building dependency packages

- and using normal workspace flag works but is ineffective and can lead to errors due to still open npm/rfcs#548

* update jsonl

* ts back to v4, accidentaly chosen by resolving merge conflict

* build local

* clean install to try to solve install module not found

* another pack-lock update

* fix linter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VIS-problem with alias
2 participants