added enhanced adapter license info to schema and types #2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foxriver76
changed the title
Apollon77
reviewed
Jan 26, 2024
|
Please sync with @bluefox and @UncleSamSwiss (?) too if current license field gets cahnged as adapter checker and dev portal need to be adapted ruther fast to avoid possible false positives. |
|
@mcm1957 as it will break admin, we will go with a new flag and deprecate the "old one", which is duplicated to the pack.json attribute anyway. We also made the new field "mandatory" in the schema. We will likely need adapter checker update (?) and update of adapter creator. Creator should simply default to type |
Apollon77
approved these changes
Jan 28, 2024
foxriver76
added a commit
that referenced
this pull request
Jan 28, 2024
* added license info * fix update license script * format * deprecate common.license and introduce common.licenseInformation * rm local schema from controller iopack * bring back license for adapter tests
foxriver76
added a commit
that referenced
this pull request
Jan 29, 2024
* optimize the upload procedure (#2589) - closes #2538 * fixed problem that cb is never called on mh enable/disable (#2557) * fixed problem that cb is never called on mh enable/disable * fix type * added enhanced adapter license info to schema and types (#2591) * added license info * fix update license script * format * deprecate common.license and introduce common.licenseInformation * rm local schema from controller iopack * bring back license for adapter tests * WIP placeholder added * prevent issue when values with stateNs.null exist in the database (#2580) * prevent issue when values with stateNs.null exist in the database - closes #2579 * rm log * rm anoither log * allow path aliases in adapter package * rm types from validator again * move tsc-alias to postbuild * use lerna to build project again as npm workspaces does not use the correct build script when building dependency packages - and using normal workspace flag works but is ineffective and can lead to errors due to still open npm/rfcs#548 * update jsonl * ts back to v4, accidentaly chosen by resolving merge conflict * build local * clean install to try to solve install module not found * another pack-lock update * fix linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.