register iobroker.blebox adapter

[ka-vaNu]

Please publish my adapter to the official list.

[Apollon77]

Hi, normally you first add it to the latest repository :-) Can you please add it there too?

[ka-vaNu]

Hi, normally you first add it to the latest repository :-) Can you please add it there too?

OK, how do i commit to the latest repository? The only open branches are "master", "ocpp" and "AlCalzone-patch-8" regarding to https://github.com/ioBroker/ioBroker.repositories/branches/active

[Apollon77]

just add it to https://github.com/ioBroker/ioBroker.repositories/blob/master/sources-dist.json ... also see the README of this project ... all infos are in there :-))

[ka-vaNu]

addToLatest fails with the following message:

`C:\Workspace\ioBroker.repositories>npm run addToLatest -- --name iobroker.blebox --type iot-systems

iobroker.repositories@1.0.4 addToLatest
node lib/scripts.js addToLatest "--name" "iobroker.blebox" "--type" "iot-systems"

ERROR: Request failed with status code 404`

[Apollon77]

Please remove this one line https://github.com/ioBroker/ioBroker.repositories/pull/1604/files#diff-1384831e45cb5b5fc71b065c642c35169d0ee196221e07b4b81075a0d3b0aed8R131 and we are fine :)

[Apollon77]

(Latest repo gets version from npm twice a day automatically)

[ka-vaNu]

Thanks for your support, i was totally confused...

[GermanBluefox]

Automated adapter checker

ioBroker.blebox

👍 No errors found

• 👀 [W400] Cannot find "blebox" in latest repository

Add comment "RE-CHECK!" to start check anew

[Apollon77]

this message is normal because not yet approved for latest ... all fine

[Apollon77]

I will do an Adapter review next

[Apollon77]

Hi, here some review comments:

• What you do with this? https://github.com/ka-vaNu/ioBroker.blebox/blob/master/main.js#L39-L42
• Please clewanup Readme and maybe add some moer infos for the users? ;-) https://github.com/ka-vaNu/ioBroker.blebox#blebox-adapter-for-iobroker
• Please translate the io-package fields (beside news) in all languages ... you can use iobroker translation tool for it, see readme of this repo
• Please add missing config values (extLog) to io-package with the default value. But normally there are several loglevels ... why nopt use these? Users can switch debug levels. Or is it that much that you fear performance issues?
• Plesse clean all schedules, timeouts, intervals and all such in "Unload" call! Clao close all connections or other used resources!
• In onStateChange you should only react on changes with state.ack===false ... or is there a reason to also react on ack=true in your case?
• Please check all used roles ... a numbr or boolean with role "text" makes no sense! --> https://github.com/ioBroker/ioBroker/blob/master/doc/STATE_ROLES.md
• For number values that have a meaning you can use common.states to give that conect for UIs ... then you could also use such nimbers for controlling commands (like your "u"/"d" and such ---> https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/objectsschema.md#attributes-for-specific-object-types

Please check the comments and adjust. Thank you

[ka-vaNu]

• What you do with this? https://github.com/ka-vaNu/ioBroker.blebox/blob/master/main.js#L39-L42
• Please clewanup Readme and maybe add some moer infos for the users? ;-) https://github.com/ka-vaNu/ioBroker.blebox#blebox-adapter-for-iobroker
• Please translate the io-package fields (beside news) in all languages ... you can use iobroker translation tool for it, see readme of this repo
• Please add missing config values (extLog) to io-package with the default value. But normally there are several loglevels ... why nopt use these? Users can switch debug levels. Or is it that much that you fear performance issues?

The extLog is very talkative. I only use it for development. The log would fill up very quickly.

• Plesse clean all schedules, timeouts, intervals and all such in "Unload" call! Clao close all connections or other used resources!
• In onStateChange you should only react on changes with state.ack===false ... or is there a reason to also react on ack=true in your case?
• Please check all used roles ... a numbr or boolean with role "text" makes no sense! --> https://github.com/ioBroker/ioBroker/blob/master/doc/STATE_ROLES.md
• For number values that have a meaning you can use common.states to give that conect for UIs ... then you could also use such nimbers for controlling commands (like your "u"/"d" and such ---> https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/objectsschema.md#attributes-for-specific-object-types

[ka-vaNu]

I published a new version 0.1.2 after adjusting the issues mentioned above

[Apollon77]

Hi,

formally https://github.com/ka-vaNu/ioBroker.blebox/blob/master/main.js#L288 is wrong ... a state got deleted if the state object is null. Ack=false are all state changes that the adapter does itself ... so this should log many times the "is deleted". I think you want to fix that before add it, or.

[ka-vaNu]

OK, thanks for the codereview & feedback. Fixed the else-block issue and send ack=true in case of updates from adapter.