Fixed bug in dimension handling in Columns.reindex

holoviz · Jan 13, 2016 · 868a91a · 868a91a
1 parent 331c27a
commit 868a91a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/holoviews/core/data.py b/holoviews/core/data.py
@@ -189,12 +189,12 @@ def reindex(self, kdims=None, vdims=None):
         converting key dimensions to value dimensions and vice versa.
         """
         if kdims is None:
-            key_dims = [d for d in self.kdims if d not in vdims]
+            key_dims = [d for d in self.kdims if not vdims or d not in vdims]
         else:
             key_dims = [self.get_dimension(k) for k in kdims]
 
         if vdims is None:
-            val_dims = [d for d in self.vdims if d not in kdims]
+            val_dims = [d for d in self.vdims if not kdims or d not in kdims]
         else:
             val_dims = [self.get_dimension(v) for v in vdims]