Skip to content

Commit

Permalink
Fixed bug in Graph edge hover info
Browse files Browse the repository at this point in the history
  • Loading branch information
philippjfr committed Sep 25, 2017
1 parent f193a4b commit c0c2399
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
4 changes: 3 additions & 1 deletion holoviews/plotting/bokeh/graphs.py
Expand Up @@ -59,7 +59,9 @@ def _hover_opts(self, element):
if self.inspection_policy == 'nodes':
dims = element.nodes.dimensions()[2:]
elif self.inspection_policy == 'edges':
dims = element.kdims+element.vdims
kdims = [(kd.pprint_label, '@{%s}' % ref)
for kd, ref in zip(element.kdims, ['start', 'end'])]
dims = kdims+element.vdims
else:
dims = []
return dims, {}
Expand Down
9 changes: 9 additions & 0 deletions tests/testbokehgraphs.py
Expand Up @@ -84,6 +84,15 @@ def test_graph_inspection_policy_edges(self):
self.assertEqual(hover.tooltips, [('start', '@{start}'), ('end', '@{end}')])
self.assertIn(renderer, hover.renderers)

def test_graph_inspection_policy_edges_non_default_names(self):
graph = self.graph.redim(start='source', end='target')
plot = bokeh_renderer.get_plot(graph.opts(plot=dict(inspection_policy='edges')))
renderer = plot.handles['glyph_renderer']
hover = plot.handles['hover']
self.assertIsInstance(renderer.inspection_policy, EdgesAndLinkedNodes)
self.assertEqual(hover.tooltips, [('source', '@{start}'), ('target', '@{end}')])
self.assertIn(renderer, hover.renderers)

def test_graph_inspection_policy_none(self):
plot = bokeh_renderer.get_plot(self.graph.opts(plot=dict(inspection_policy=None)))
renderer = plot.handles['glyph_renderer']
Expand Down

0 comments on commit c0c2399

Please sign in to comment.