Fixed initialization of scrubber widget (#3225)

holoviz · Nov 29, 2018 · f27deb2 · f27deb2
1 parent bea0f54
commit f27deb2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/holoviews/plotting/bokeh/widgets.py b/holoviews/plotting/bokeh/widgets.py
@@ -274,10 +274,6 @@ class BokehWidget(NdWidget):
         Optional javascript extension file for a particular backend.""")
 
     def _get_data(self):
-        # Get initial frame to draw immediately
-        if not self.plot.dynamic:
-            _, _, init_dim_vals = self.get_widgets()
-            self.plot.update(tuple(init_dim_vals))
         msg, metadata = self.renderer.components(self.plot, comm=False)
         data = super(BokehWidget, self)._get_data()
         return dict(data, init_html=msg['text/html'],
@@ -316,8 +312,12 @@ def _plot_figure(self, idx, fig_format='json'):
 
 
 class BokehSelectionWidget(BokehWidget, SelectionWidget):
-    pass
 
+    def _get_data(self):
+        if not self.plot.dynamic:
+            _, _, init_dim_vals = self.get_widgets()
+            self.plot.update(tuple(init_dim_vals))
+        return super(BokehSelectionWidget, self)._get_data()
 
 class BokehScrubberWidget(BokehWidget, ScrubberWidget):
     pass
diff --git a/holoviews/plotting/plotly/widgets.py b/holoviews/plotting/plotly/widgets.py
@@ -9,10 +9,6 @@ class PlotlyWidget(NdWidget):
         Optional javascript extension file for a particular backend.""")
 
     def _get_data(self):
-        # Get initial frame to draw immediately
-        if not self.plot.dynamic:
-            _, _, init_dim_vals = self.get_widgets()
-            self.plot.update(tuple(init_dim_vals))
         msg, metadata = self.renderer.components(self.plot, divuuid=self.id, comm=False)
         data = super(PlotlyWidget, self)._get_data()
         return dict(data, init_html=msg['text/html'],
@@ -33,7 +29,12 @@ def _plot_figure(self, idx, fig_format='json'):
 
 
 class PlotlySelectionWidget(PlotlyWidget, SelectionWidget):
-    pass
+
+    def _get_data(self):
+        if not self.plot.dynamic:
+            _, _, init_dim_vals = self.get_widgets()
+            self.plot.update(tuple(init_dim_vals))
+        return super(PlotlySelectionWidget, self)._get_data()
 
 class PlotlyScrubberWidget(PlotlyWidget, ScrubberWidget):
     pass