New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle document creation directly #1197

Merged
merged 1 commit into from Mar 12, 2017

Conversation

Projects
None yet
3 participants
@philippjfr
Member

philippjfr commented Mar 12, 2017

In the latest bokeh dev builds the _ModelInDocument context manager was moved and changed. Rather than relying on it, we simply create a new Document per plot and detach the Document from all existing models.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Mar 12, 2017

Seems fine to be explicit and I am assuming this has been tested with latest bokeh dev and previous versions.

Both versions access underscore attributes: doc_handler._doc in the old version and now m._document. On that basis we are still relying on internal bokeh API but this version should at least work with the next bokeh release.

Merging.

@jlstevens jlstevens merged commit 26d2072 into master Mar 12, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on bokeh_renderer_0.12.5 at 78.496%
Details

@jbednar jbednar deleted the bokeh_renderer_0.12.5 branch Mar 12, 2017

@jbednar

This comment has been minimized.

Member

jbednar commented Mar 12, 2017

Please file an issue on Bokeh asking that there be a defended API entry point to wrap anything we are relying on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment