Added hv.examples to copy notebooks locally #1368
Conversation
holoviews/__init__.py
Outdated
| import os, glob | ||
| from shutil import copytree, ignore_patterns | ||
|
|
||
| candidates = [os.path.join(__path__[0], '../doc/Tutorials/'), # local doc available |
There was a problem hiding this comment.
"local doc available" means git? If so maybe say so.
There was a problem hiding this comment.
Yes, I mean git. I'll update shortly.
setup.py
Outdated
| if __name__=="__main__": | ||
| def pypi_version(pypi=False): | ||
| if not pypi: return | ||
| # Make sure to create these directories and populate them before upload |
There was a problem hiding this comment.
Not sure what that comment means; surely there is no manual step involved?
There was a problem hiding this comment.
Right now there is a manual step. Populating the pseudo packages is also a manual step.
I'm all in favor of replacing the manual steps with something else... as long as it works!
There was a problem hiding this comment.
Right. I don't see any reason to have a manual step!
|
Any idea what these errors are about? Somehow option IDs are now wrong: https://travis-ci.org/ioam/holoviews/jobs/225631022 |
philippjfr
force-pushed
the
examples_function
branch
from
ce25010
to
b9a5fe4
Compare
|
@philippjfr Thanks for doing this and I do think it is the right approach. As I don't think our notebooks are quite ready to ship in the current state, I'm assigning this to the 1.8 milestone. |
|
I've reassigned this to 1.7.1 as the notebooks and examples should be presentable at that point. |
|
Will have to update this once we have all the assets and examples in place. |
philippjfr
force-pushed
the
examples_function
branch
from
18d7e73
to
4f9068b
Compare
| @@ -35,7 +35,7 @@ install: | |||
| conda install python=3.4.3; | |||
| fi | |||
| - rm -r $SITE_PACKAGES/numpy* | |||
| - python setup.py install | |||
There was a problem hiding this comment.
Why did this need to change?
There was a problem hiding this comment.
So it skips installing the examples mainly. If you use develop then the examples are already in a place where it will find them.
There was a problem hiding this comment.
Makes sense, thanks.
philippjfr
force-pushed
the
examples_function
branch
from
4f9068b
to
071fd00
Compare
|
There seems to be an issue with having to run |
There may be a better approach but this stuff is very tricky. I'm fairly sure this approach will work:
1 - Set
pypi_version(True)only when building for PyPI.2 - Get conda to copy the notebooks to a path in the same way datashader does it.