Reverse map renamed stream parameters in dynamic operations #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready to review/merge. |
|
The title of this issue wins today's Most Difficult to Parse award! Only the most deeply versed in HoloViews lingo will be able to distinguish it from a random string of words. Congratulations! Well done! :-) |
|
@jbednar Don't worry, I had to ask Philipp what it was all about too! Anyway, now I understand it, I am happy to merge. The main issue here is (as we already know!) we need a lot more documentation. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streams can inherit parameters from dynamic operations when their values are None. However this currently breaks for renamed parameters because the operation and stream parameters do not match in those cases. This PR ensures that renamed stream parameters are reverse mapped fixing the bug.