Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added simpler .hist example #1663

Merged
merged 2 commits into from
Sep 29, 2017
Merged

Added simpler .hist example #1663

merged 2 commits into from
Sep 29, 2017

Conversation

jbednar
Copy link
Member

@jbednar jbednar commented Jun 30, 2017

The Histogram page in the Reference Gallery didn't have a simple example of using '.hist()', which is typically much more convenient than the complex example shown. Added this simple example:

image

Works fine for Bokeh, but in mpl there is a strange colormap:

image

The last example on that page (not really modified in this PR) is also aligned and sized very strangely for matplotlib, though it works fine for bokeh:

image

@jlstevens jlstevens added the type: bug Something isn't correct or isn't working label Jun 30, 2017
@jlstevens
Copy link
Contributor

That is a worthwhile example to add. Best we wait to see which of those matplotlib bugs can be fixed before merging.

@philippjfr
Copy link
Member

Will see, dealing with adjoints more generally in matplotlib has been a longstanding issue (see #1033).

@jlstevens
Copy link
Contributor

@philippjfr Should we merge despite the weird matplotlib output?

@philippjfr
Copy link
Member

I'll see if I can deal with the wrong colormapping at least. Doubt I'll be able to fix the sizing issue easily.

@philippjfr
Copy link
Member

@jbednar Would you mind updating this PR by setting an explicit range for the x and y dimensions? For now matplotlib won't normalize the points and histogram together so you end up with different scales.

@jbednar
Copy link
Member Author

jbednar commented Sep 25, 2017

It sounds like you know what's needed; can you just push what you suggest to the PR?

@philippjfr
Copy link
Member

Done. @jlstevens ready to merge when tests pass.

@jlstevens
Copy link
Contributor

Looks good and the tests are passing. Merging.

@jlstevens jlstevens merged commit 99f248b into master Sep 29, 2017
@philippjfr philippjfr deleted the hist-ex branch October 9, 2017 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants