New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting started guide tweaks #1664

Merged
merged 4 commits into from Aug 11, 2017

Conversation

Projects
None yet
3 participants
@jlstevens
Member

jlstevens commented Jul 1, 2017

PR to make small fixes to the getting started guide.

I'll update the online HTML manually to reflect the changes in the first two commits.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jul 7, 2017

@philippjfr I think I recommend merging this for 1.8.1. Work can continue in a new PR...

@philippjfr

This comment has been minimized.

Member

philippjfr commented Aug 11, 2017

Looks like I missed this. Is it still ready to merge?

@jlstevens

This comment has been minimized.

Member

jlstevens commented Aug 11, 2017

I think so, yes.

@philippjfr philippjfr merged commit 861ba66 into master Aug 11, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 79.676%
Details
s3-reference-data-cache Tests passing no test data changes required.
Details

@jlstevens jlstevens added this to the 1.8.3 milestone Aug 21, 2017

@philippjfr philippjfr deleted the getting_started_guide_tweaks branch Aug 21, 2017

@@ -44,7 +44,7 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"This is the standard way to make the numpy and pandas libraries available in the namespace. We recommend always importing HoloViews as ``hv`` and if you haven't already installed HoloViews, check out our [installation page].\n",
"This is the standard way to make the numpy and pandas libraries available in the namespace. We recommend always importing HoloViews as ``hv`` and if you haven't already installed HoloViews, check out the install instructions on our [homepage](www.holoviews.org).\n",

This comment has been minimized.

@ymr1

ymr1 Nov 7, 2017

It seems there is bad link to homepage.
The right one should be http://www.holoviews.org

This comment has been minimized.

@philippjfr

philippjfr Nov 7, 2017

Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment