New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set SpikesPlot color index to None by default #1671

Merged
merged 5 commits into from Jul 7, 2017

Conversation

Projects
None yet
2 participants
@jlstevens
Member

jlstevens commented Jul 2, 2017

Before:

After:

I think this is a bug fix, not a style change as before a vdim was being mapped to both height and color when it should only be mapped to height.

@jlstevens jlstevens added this to the v1.8.1 milestone Jul 2, 2017

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jul 2, 2017

Test data will need update. Also should mention this PR addresses #1669.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jul 2, 2017

I'll update the colormap to 'fire' before updating the display data though...

jlstevens added some commits Jul 6, 2017

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jul 7, 2017

@philippjfr pr builds are finally green. Ready to merge.

@philippjfr philippjfr merged commit 82c9e17 into master Jul 7, 2017

3 of 4 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.002%) to 79.674%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the spike_color_index_fix branch Jul 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment